linux-kernel - Re: [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c52378b8-1690-42cc-a7dd-f938dcbfa708@intel.com>
Date: Tue, 20 Jan 2026 15:28:43 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Linus Walleij <linusw@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Linus Walleij
	<linus.walleij@...aro.org>
Subject: Re: [PATCH v3] mmc: sdhci: Stop advertising the driver in dmesg

On 20/01/2026 15:05, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
> 
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
> 
> Drop all messages from sdhci_drv_init(), and drop the
> module_init() and module_exit() calls as well since they
> now become empty.
> 
> The modules becomes a pure library module, meaning it will
> get pulled in by modprobe() when the symbols inside it
> are needed, or compiled in if any users are compiled in.
> Kconfig already makes sure this module is compiled in
> the users are compiled in.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> Changes in v3:
> - Rebased on v6.19-rc1
> - Link to v2: https://lore.kernel.org/r/20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org
> 
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
>  drivers/mmc/host/sdhci.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af7..1ff15fa9b042 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4997,22 +4997,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>   *                                                                           *
>  \*****************************************************************************/
>  
> -static int __init sdhci_drv_init(void)
> -{
> -	pr_info(DRIVER_NAME
> -		": Secure Digital Host Controller Interface driver\n");
> -	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
> -	return 0;
> -}
> -
> -static void __exit sdhci_drv_exit(void)
> -{
> -}
> -
> -module_init(sdhci_drv_init);
> -module_exit(sdhci_drv_exit);
> -
>  module_param(debug_quirks, uint, 0444);
>  module_param(debug_quirks2, uint, 0444);
>  
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
> 
> Best regards,