linux-kernel - Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW7xdw8mF8hkd/5O@intel.com>
Date: Tue, 20 Jan 2026 11:07:35 +0800
From: Chao Gao <chao.gao@...el.com>
To: Dave Hansen <dave.hansen@...ux.intel.com>
CC: <linux-kernel@...r.kernel.org>, <sohil.mehta@...el.com>, Borislav Petkov
	<bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar
	<mingo@...hat.com>, Jon Kohler <jon@...anix.com>, Pawan Gupta
	<pawan.kumar.gupta@...ux.intel.com>, "Peter Zijlstra (Intel)"
	<peterz@...radead.org>, Thomas Gleixner <tglx@...nel.org>, Tony Luck
	<tony.luck@...el.com>, <x86@...nel.org>
Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into
 a helper

On Mon, Jan 19, 2026 at 11:50:53AM -0800, Dave Hansen wrote:
>
>From: Dave Hansen <dave.hansen@...ux.intel.com>
>
>The only code that cares about the platform ID is the microcode update
>code itself. To facilitate storing the platform ID in a more generic
>place and using it outside of the microcode update itself, put the
>enumeration into a helper function in a header. Mirror
>intel_get_microcode_revision()'s naming and location.
>
>But, moving away from intel_collect_cpu_info() means that the model
>and family information in CPUID is not readily available. Just call
>CPUID again.
>
>Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
>Cc: Thomas Gleixner <tglx@...nel.org>
>Cc: Ingo Molnar <mingo@...hat.com>
>Cc: Borislav Petkov <bp@...en8.de>
>Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>Cc: "H. Peter Anvin" <hpa@...or.com>
>Cc: Tony Luck <tony.luck@...el.com>
>Cc: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
>Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>
>Cc: x86@...nel.org
>Cc: Jon Kohler <jon@...anix.com>
>---
>
> b/arch/x86/include/asm/microcode.h      |   31 +++++++++++++++++++++++++++++++
> b/arch/x86/kernel/cpu/microcode/intel.c |   10 +---------
> 2 files changed, 32 insertions(+), 9 deletions(-)
>
>diff -puN arch/x86/include/asm/microcode.h~refactor-get-processor-flags arch/x86/include/asm/microcode.h
>--- a/arch/x86/include/asm/microcode.h~refactor-get-processor-flags	2026-01-19 11:38:08.775892390 -0800
>+++ b/arch/x86/include/asm/microcode.h	2026-01-19 11:38:08.783892696 -0800
>@@ -2,7 +2,9 @@
> #ifndef _ASM_X86_MICROCODE_H
> #define _ASM_X86_MICROCODE_H
> 
>+#include <asm/cpu.h>
> #include <asm/msr.h>
>+#include <asm/intel-family.h>

nit: You may want to sort the header files alphabetically.