[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABZAGRECCp889_MBAJyU+TvG_Z7xkZP0414XFoQJw2a8BwzT4Q@mail.gmail.com>
Date: Tue, 20 Jan 2026 11:11:51 +0800
From: Nick Huang <sef1548@...il.com>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, kusogame68@...il.com, paladin@...b.edu.tw,
n1136402@...b.edu.tw, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/test_min_heap: fix incorrect module description
Kuan-Wei Chiu <visitorckw@...il.com> 於 2026年1月19日週一 下午10:06寫道:
>
> Hi Nick,
>
> On Mon, Jan 19, 2026 at 09:46:05PM +0800, Nick Huang wrote:
> > Kuan-Wei Chiu <visitorckw@...il.com> 於 2026年1月19日週一 下午9:26寫道:
> >
> > > Hi Nick,
> > >
> > > On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> > > > The module description incorrectly mentions "min max heap", but the
> > > > test module is specifically designed for testing the min heap
> > > > implementation. Correct the metadata to match the code.
> > >
> > > Thanks for the patch, but I don't think this change is necessary.
> > >
> > > As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
> > > the implementation easily supports a max heap by simply inverting
> > > the comparison function.
> > >
> > > Since this module explicitly tests both min heap and max heap
> > > scenarios, the current description accurately reflects the test
> > > coverage.
> > >
> > > Regards,
> > > Kuan-Wei
> > >
> >
> > Hi Kuan-Wei
> >
> > Thanks for your clarification!
> >
> For future reference, please ensure your emails are plain text only,
> without html or base64 encoding.
>
> Regards,
> Kuan-Wei
>
Hi Kuan-Wei
Thanks for the reminder. I'll make sure to send my future emails in
plain text only.
Regards,
Nick Huang
Powered by blists - more mailing lists