linux-kernel - Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW-LOZdXo6zLhT_x@smile.fi.intel.com>
Date: Tue, 20 Jan 2026 16:03:37 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Minu Jin <s9430939@...er.com>, gregkh@...uxfoundation.org,
	abrahamadekunle50@...il.com, milospuric856@...il.com,
	zxcv2569763104@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of
 skb_copy_bits

On Tue, Jan 20, 2026 at 04:59:29PM +0300, Dan Carpenter wrote:
> On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote:

...

> > +	signed int ret;
> 
> Don't put a blank line in the middle of the declaration block.  Just do
> "int ret;".  Everyone knows "int" is signed.  Don't follow the local
> style when the local style is wrong.  Also only use s32 when it's part
> of a networking or hardware spec.  Just use int.  Do people imagine that
> we'll change int to be unsigned?

Not in a far past we changed char to be unsigned :-)

*Yes I know that it's a bit different case.

-- 
With Best Regards,
Andy Shevchenko