linux-kernel - Re: [PATCH v10 2/7] platform/x86: Rename lenovo-wmi-capdata01 to lenovo-wmi-capdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c437e6e73d74b7aedd269328e1b0411a110444d3.camel@rong.moe>
Date: Tue, 20 Jan 2026 23:20:56 +0800
From: Rong Zhang <i@...g.moe>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
 "Derek J. Clark" <derekjohn.clark@...il.com>
Cc: Mark Pearson <mpearson-lenovo@...ebb.ca>, Armin Wolf <W_Armin@....de>, 
 Hans de Goede <hansg@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Kurt
 Borja <kuurtb@...il.com>, 	platform-driver-x86@...r.kernel.org, LKML
 <linux-kernel@...r.kernel.org>, 	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v10 2/7] platform/x86: Rename lenovo-wmi-capdata01 to
 lenovo-wmi-capdata

On Tue, 2026-01-20 at 16:48 +0200, Ilpo Järvinen wrote:
> On Sun, 18 Jan 2026, Rong Zhang wrote:
> 
> > Prepare for the upcoming changes to make it suitable to retrieve
> > and provide other Capability Data as well.
> > 
> > Signed-off-by: Rong Zhang <i@...g.moe>
> > Reviewed-by: Derek J. Clark <derekjohn.clark@...il.com>
> > Tested-by: Derek J. Clark <derekjohn.clark@...il.com>
> > ---
> >  drivers/platform/x86/lenovo/Kconfig           |   4 +-
> >  drivers/platform/x86/lenovo/Makefile          |   2 +-
> >  .../lenovo/{wmi-capdata01.c => wmi-capdata.c} | 124 +++++++++---------
> >  .../lenovo/{wmi-capdata01.h => wmi-capdata.h} |  10 +-
> >  drivers/platform/x86/lenovo/wmi-other.c       |  11 +-
> >  5 files changed, 78 insertions(+), 73 deletions(-)
> >  rename drivers/platform/x86/lenovo/{wmi-capdata01.c => wmi-capdata.c} (60%)
> >  rename drivers/platform/x86/lenovo/{wmi-capdata01.h => wmi-capdata.h} (60%)
> > 
> > diff --git a/drivers/platform/x86/lenovo/Kconfig b/drivers/platform/x86/lenovo/Kconfig
> > index d22b774e0236f..fb96a0f908f03 100644
> > --- a/drivers/platform/x86/lenovo/Kconfig
> > +++ b/drivers/platform/x86/lenovo/Kconfig
> > @@ -233,7 +233,7 @@ config YT2_1380
> >  	  To compile this driver as a module, choose M here: the module will
> >  	  be called lenovo-yogabook.
> >  
> > -config LENOVO_WMI_DATA01
> > +config LENOVO_WMI_DATA
> >  	tristate
> >  	depends on ACPI_WMI
> 
> This series is in the review-ilpo-next branch now. Thanks to all who have 
> participated in getting it into shape!

Thank you for review and merging too! And thanks to Armin, Derek and
Kurt for review and testing! ;-)

> While reading it through once again while applying, I start to wonder if 
> this config would be better named as LENOVO_WMI_CAPDATA ?

I didn't thought of that when I substituted all occurrences of
data01/cd01 with data/cd, but it's definitely a better name for me when
it pops out.

Hmm... Wait, we have

 	.driver = {
-		.name = "lenovo_wmi_cd01",
+		.name = "lenovo_wmi_cd",
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
 	},

What about adopting the same name here to make everything more
consistent? Having a unified name will be neater. @Derek, what do you
think?

Thank you all,
Rong