linux-kernel - Re: [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fe80f4a-ef5c-4008-88e2-60ad1f8c2a18@oss.qualcomm.com>
Date: Tue, 20 Jan 2026 15:39:44 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Luca Weiss <luca.weiss@...rphone.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Alexander Koskovich <AKoskovich@...me>,
        Jeff Johnson <jeff.johnson@....qualcomm.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node

On 1/16/26 3:50 PM, Luca Weiss wrote:
> Add a node for the WCN6750 WiFi found with the Milos SoC.
> 
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> ---
>  arch/arm64/boot/dts/qcom/milos.dtsi | 46 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index 024e1c9992fe..80feb3e9d3e2 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -2043,6 +2043,52 @@ gic_its: msi-controller@...40000 {
>  			};
>  		};
>  
> +		wifi: wifi@...10040 {
> +			compatible = "qcom,wcn6750-wifi";
> +			reg = <0x0 0x17110040 0x0 0x0>;

This reg doesn't.. sound.. very.. good..

The size being 0 is of course wrong, but perhaps more interestingly
the base address is a register within the GIC..

> +			iommus = <&apps_smmu 0x1400 0x1>;

And this is a PCIe stream

But I see kodiak has the exact same setup..

After digging a little into the driver, that 'reg' is apparently
indeed consumed, as a base for PCI MSIs.. I feel like there should be
some better way to express this.. non-everyday setup

There's this commit message:

commit 00fd24089b8154ddf5b3e724e2c4c9974b9ba91e
Author: Manikanta Pubbisetty <quic_mpubbise@...cinc.com>
Date:   Fri Apr 29 22:34:54 2022 +0530

    dt: bindings: net: add bindings of WCN6750 for ath11k
    
    WCN6750 is the WLAN chip on Qualcomm Snapdragon SoC SC7280;
    Though being a PCIe based solution, it is not attached to
    the APSS processor (Application Processor SubSystem), it is
    instead attached to another tiny processor called WPSS Q6
    processor (Wireless Processor SubSystem) on the SC7280 MSM,
    where the WLAN firmware runs, and it is the WLAN firmware
    running on the Q6 processor which enumerates WCN6750, as a
    result APPS processor would never know such a device being
    present in the system and would not detect the WCN6750
    hardware unless and otherwise WCN6750 is registered as a
    platform device. This is the reason behind adding WCN6750
    WLAN node in the device tree.
    
    Add WCN6750 wireless driver support, its based on ath11k driver.

Sorry to hijack this patch, but I am not comfortable with this binding
as-is..

Adding +Jeff in case he has any thoughts

Konrad