[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3f3c47ea-1660-4bd4-ab89-3bdf58217995@kernel.org>
Date: Tue, 20 Jan 2026 15:31:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sudarshan Shetty <tessolveupstream@...il.com>, lee@...nel.org,
danielt@...nel.org, jingoohan1@...il.com
Cc: deller@....de, pavel@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, dri-devel@...ts.freedesktop.org,
linux-fbdev@...r.kernel.org, linux-leds@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: gpio-backlight: allow
multiple GPIOs
On 20/01/2026 13:50, Sudarshan Shetty wrote:
> Update the gpio-backlight binding to support configurations that require
> more than one GPIO for enabling/disabling the backlight.
Why? Which devices need it? How a backlight would have three enable
GPIOs? I really do not believe, so you need to write proper hardware
justification.
>
> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> ---
> .../leds/backlight/gpio-backlight.yaml | 24 +++++++++++++++++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> index 584030b6b0b9..4e4a856cbcd7 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/gpio-backlight.yaml
> @@ -16,8 +16,18 @@ properties:
> const: gpio-backlight
>
> gpios:
> - description: The gpio that is used for enabling/disabling the backlight.
> - maxItems: 1
> + description: |
> + The gpio that is used for enabling/disabling the backlight.
> + Multiple GPIOs can be specified for panels that require several
> + enable signals. All GPIOs are controlled together.
> + type: array
There is no such syntax in the bindings, from where did you get it? Type
is already defined.
items:
minItems: 1
maxItems: 3
> + minItems: 1
> + items:
> + type: array
> + minItems: 3
> + maxItems: 3
> + items:
> + type: integer
All this is some odd stuff - just to be clear, don't send us LLM output.
I don't want to waste my time to review microslop.
Was it done with help of Microslop?
Best regards,
Krzysztof
Powered by blists - more mailing lists