linux-kernel - Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd1c29e3-3575-4f42-8e72-db2514b3b4bb@intel.com>
Date: Tue, 20 Jan 2026 07:06:56 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, sohil.mehta@...el.com,
 Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
 Ingo Molnar <mingo@...hat.com>, Jon Kohler <jon@...anix.com>,
 Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Thomas Gleixner <tglx@...nel.org>, Tony Luck <tony.luck@...el.com>,
 x86@...nel.org
Subject: Re: [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure

On 1/20/26 00:27, Andy Shevchenko wrote:
...
>> Note: This should not grow the size of 'struct cpuinfo_x86' in
>> practice since the u8 fits next to another u8 in the structure.
> 
> Have you run `pahole` to confirm?

I have not. If you'd like to contribute to the series by compiling this
and running pahole on it, I'd very much appreciate it!

> ...
> 
>>  	c->x86_cache_size = 0;
>>  	c->x86_vendor = X86_VENDOR_UNKNOWN;
>> -	c->x86_model = c->x86_stepping = 0;	/* So far unknown... */
> 
> Shan't we preserve the comment?
> 
> 	/* So far model, stepping, and platform_id are unknown... */

... and cache size and vendor and everything else. It's not a super
useful comment.