[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <71935526c5cc6580a1b7ccf3446adca16387eef2.camel@rong.moe>
Date: Wed, 21 Jan 2026 02:26:01 +0800
From: Rong Zhang <i@...g.moe>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Mark Pearson <mpearson-lenovo@...ebb.ca>, "Derek J. Clark"
<derekjohn.clark@...il.com>, Armin Wolf <W_Armin@....de>, Hans de Goede
<hansg@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Kurt Borja
<kuurtb@...il.com>, platform-driver-x86@...r.kernel.org, LKML
<linux-kernel@...r.kernel.org>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v10 2/7] platform/x86: Rename lenovo-wmi-capdata01 to
lenovo-wmi-capdata
Hi Ilpo,
On Tue, 2026-01-20 at 16:48 +0200, Ilpo Järvinen wrote:
> On Sun, 18 Jan 2026, Rong Zhang wrote:
>
> > Prepare for the upcoming changes to make it suitable to retrieve
> > and provide other Capability Data as well.
> >
> > Signed-off-by: Rong Zhang <i@...g.moe>
> > Reviewed-by: Derek J. Clark <derekjohn.clark@...il.com>
> > Tested-by: Derek J. Clark <derekjohn.clark@...il.com>
> > ---
> > drivers/platform/x86/lenovo/Kconfig | 4 +-
> > drivers/platform/x86/lenovo/Makefile | 2 +-
> > .../lenovo/{wmi-capdata01.c => wmi-capdata.c} | 124 +++++++++---------
> > .../lenovo/{wmi-capdata01.h => wmi-capdata.h} | 10 +-
> > drivers/platform/x86/lenovo/wmi-other.c | 11 +-
> > 5 files changed, 78 insertions(+), 73 deletions(-)
> > rename drivers/platform/x86/lenovo/{wmi-capdata01.c => wmi-capdata.c} (60%)
> > rename drivers/platform/x86/lenovo/{wmi-capdata01.h => wmi-capdata.h} (60%)
> >
> > diff --git a/drivers/platform/x86/lenovo/Kconfig b/drivers/platform/x86/lenovo/Kconfig
> > index d22b774e0236f..fb96a0f908f03 100644
> > --- a/drivers/platform/x86/lenovo/Kconfig
> > +++ b/drivers/platform/x86/lenovo/Kconfig
> > @@ -233,7 +233,7 @@ config YT2_1380
> > To compile this driver as a module, choose M here: the module will
> > be called lenovo-yogabook.
> >
> > -config LENOVO_WMI_DATA01
> > +config LENOVO_WMI_DATA
> > tristate
> > depends on ACPI_WMI
>
> This series is in the review-ilpo-next branch now. Thanks to all who have
> participated in getting it into shape!
>
> While reading it through once again while applying, I start to wonder if
> this config would be better named as LENOVO_WMI_CAPDATA ?
Thanks for your suggestion. I've sent a v11 series with consistent
naming for kmod, Kconfig, export namespace and driver.
Thanks,
Rong
Powered by blists - more mailing lists