linux-kernel - Re: [PATCH v5] driver core: enforce device_lock for driver_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b0533e8-0e69-4ce0-8550-8cfe1c71f385@sirena.org.uk>
Date: Tue, 20 Jan 2026 15:35:25 +0000
From: Mark Brown <broonie@...nel.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Gui-Dong Han <hanguidong02@...il.com>, gregkh@...uxfoundation.org,
	rafael@...nel.org, linux-kernel@...r.kernel.org,
	baijiaju1990@...il.com, Qiu-ji Chen <chenqiuji666@...il.com>,
	Aishwarya.TCV@....com
Subject: Re: [PATCH v5] driver core: enforce device_lock for
 driver_match_device()

On Tue, Jan 20, 2026 at 04:03:03PM +0100, Danilo Krummrich wrote:
> On Tue Jan 20, 2026 at 2:22 PM CET, Mark Brown wrote:

> > I'm seeing boot hangs on Arm Juno in next/pending-fixes which bisect to
> > this commit.  The boot grinds to a halt near the end of boot:

> Hm..sounds a bit like some match() callback manually takes the device_lock() and
> the reason we're not seeing anything from lockdep is because it happens with the
> serial driver.

> I don't have a machine to reproduce it, but for debugging it would probably help
> to not actually take the lock in __driver_attach(), but only acquire / release
> the corresponding lockdep map. If my suspicion is correct, we should see a
> lockdep splat pointing out the issue.

lockdep isn't enabled by any of the defconfigs so has limited test
coverage, the only one I'm seeing it enabled by is ps3_defconfig.  I'll
try to run some tests with lockdep enabled.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)