linux-kernel - Re: [PATCH v3] staging: rtl8723bs: fix unchecked return value of skb_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aW-qh9mc-Uc2eV6w@smile.fi.intel.com>
Date: Tue, 20 Jan 2026 18:17:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Minu Jin <s9430939@...er.com>
Cc: gregkh@...uxfoundation.org, abrahamadekunle50@...il.com,
	dan.carpenter@...aro.org, milospuric856@...il.com,
	zxcv2569763104@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: fix unchecked return value of
 skb_copy_bits

On Wed, Jan 21, 2026 at 12:50:34AM +0900, Minu Jin wrote:
> The function _rtw_pktfile_read() incorrectly updated the file pointer
> even when skb_copy_bits() failed.
> 
> This patch fixes the issue by:
> 
>     1. Propagating the negative error code from skb_copy_bits() if
>        it fails, preventing internal pointer updates.
> 
>     2. Updating all callers (including set_qos) to check the return value
>        and handle errors appropriately.

...

> -uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen)
> +int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen)
>  {
> -	uint	len = 0;
> +	uint len = 0;

Use
	unsigned int len;

(Note that the 0 assignment is redundant)


> +	int ret;
>  
>  	len =  rtw_remainder_len(pfile);

^^^ len is assigned here.

-- 
With Best Regards,
Andy Shevchenko