[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DFTNX1DYBXWJ.24E4YYMAJSH9N@kernel.org>
Date: Tue, 20 Jan 2026 20:27:19 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Tamir Duberstein" <tamird@...nel.org>, "Miguel Ojeda"
<ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
"Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
"Danilo Krummrich" <dakr@...nel.org>, "Jesung Yang" <y.j3ms.n@...il.com>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
"Nathan Chancellor" <nathan@...nel.org>, "Nicolas Schier" <nsc@...nel.org>,
"Linux Kbuild mailing list" <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] rust: reduce duplicate information
On Tue Jan 20, 2026 at 5:10 PM CET, Tamir Duberstein wrote:
> This series reuses `rust/Makefile`'s knowledge of `pin_init` and
> `pin_init_internal`'s `cfg`s in `scripts/generate_rust_analzyer.py` and
> reduces the ceremony needed to use that knowledge in the script.
This is a cool idea, I don't maintain the makefile code, so this doesn't
mean much, but it's on my radar :)
Acked-by: Benno Lossin <lossin@...nel.org>
Cheers,
Benno
> Signed-off-by: Tamir Duberstein <tamird@...nel.org>
> ---
> Changes in v2:
> - Split into two patches. (Miguel Ojeda)
> - CC kbuild. (Miguel Ojeda)
> - Link to v1: https://patch.msgid.link/20260116-rust-analyzer-pin-init-duplication-v1-1-5e85c5824a02@kernel.org
>
> ---
> Tamir Duberstein (2):
> rust: kbuild: extract configs for reuse
> scripts: generate_rust_analyzer.py: reduce cfg plumbing
>
> rust/Makefile | 32 +++++++++++++++++++++++---------
> scripts/generate_rust_analyzer.py | 13 +++++--------
> 2 files changed, 28 insertions(+), 17 deletions(-)
> ---
> base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
> change-id: 20260116-rust-analyzer-pin-init-duplication-a22d05221771
>
> Best regards,
> --
> Tamir Duberstein <tamird@...nel.org>
Powered by blists - more mailing lists