linux-kernel - Re: [PATCH v14 10/34] PCI/AER: Update is_internal_error() to be non-static is_aer_internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <696fb31b99b35_1d33100b0@dwillia2-mobl4.notmuch>
Date: Tue, 20 Jan 2026 08:53:47 -0800
From: <dan.j.williams@...el.com>
To: "Bowman, Terry" <terry.bowman@....com>, <dan.j.williams@...el.com>,
	<dave@...olabs.net>, <jonathan.cameron@...wei.com>, <dave.jiang@...el.com>,
	<alison.schofield@...el.com>, <bhelgaas@...gle.com>, <shiju.jose@...wei.com>,
	<ming.li@...omail.com>, <Smita.KoralahalliChannabasappa@....com>,
	<rrichter@....com>, <dan.carpenter@...aro.org>,
	<PradeepVineshReddy.Kodamati@....com>, <lukas@...ner.de>,
	<Benjamin.Cheatham@....com>, <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	<linux-cxl@...r.kernel.org>, <vishal.l.verma@...el.com>, <alucerop@....com>,
	<ira.weiny@...el.com>
CC: <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v14 10/34] PCI/AER: Update is_internal_error() to be
 non-static is_aer_internal_error()

Bowman, Terry wrote:
> On 1/19/2026 8:20 PM, dan.j.williams@...el.com wrote:
> > Terry Bowman wrote:
> >> The AER driver includes significant logic for handling CXL protocol errors.
> >> The AER driver will be updated in the future to separate the AER and CXL
> >> logic.
> >>
> >> Rename the is_internal_error() function to is_aer_internal_error() as it
> >> gives a more precise indication of the purpose. Make is_aer_internal_error()
> >> non-static to allow for other PCI drivers to access.
> > 
> > Not even sure this rename is needed given that it is private to
> > drivers/pci/pcie/ and the sharing is only for cxl_{rch,vh}.c, not for
> > "other PCI drivers". Consistent with the idea that internal errors are
> > not going to become a first-class citizen let us keep this a CXL-only
> > consideration.
> > 
> > I'll update the changelog to drop the "other PCI drivers" comment.
> 
> The name choice was addressed by Bjorn here:
> 
> https://lore.kernel.org/linux-cxl/20251208180624.GA3300935@bhelgaas/ 

Thanks, yes, I only folded in the following changes to the changelog:

10:  417535d35e9f ! 11:  098f14e1d884 PCI/AER: Update is_internal_error() to be non-static is_aer_internal_error()
    @@ Commit message
         logic.
     
         Rename the is_internal_error() function to is_aer_internal_error() as it
    -    gives a more precise indication of the purpose. Make is_aer_internal_error()
    -    non-static to allow for other PCI drivers to access.
    +    gives a more precise indication of the purpose. Make
    +    is_aer_internal_error() non-static to allow for the 2 different CXL
    +    topology error model implementations (RCH and VH) to share this helper.
     
         Signed-off-by: Terry Bowman <terry.bowman@....com>
    -
    -    ---
    -
    -    Changes in v13->v14:
    -    - New patch
    +    Link: https://patch.msgid.link/20260114182055.46029-11-terry.bowman@amd.com
    +    Signed-off-by: Dan Williams <dan.j.williams@...el.com>