[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260120-renewal-iphone-631b72e757bb@spud>
Date: Tue, 20 Jan 2026 19:49:02 +0000
From: Conor Dooley <conor@...nel.org>
To: tzeyee.ng@...era.com
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: socfpga: stratix10: Add emmc support
On Tue, Jan 20, 2026 at 05:54:46AM -0800, tzeyee.ng@...era.com wrote:
> From: Ng Tze Yee <tzeyee.ng@...era.com>
>
> The Stratix10 devkit supports a separate eMMC daughter card. The eMMC
> daughter card replaces the SDMMC slot that is on the default daughter card
> and thus requires a separate board dts file.
>
> Signed-off-by: Ng Tze Yee <tzeyee.ng@...era.com>
> ---
> arch/arm64/boot/dts/altera/Makefile | 1 +
> .../altera/socfpga_stratix10_socdk_emmc.dts | 155 ++++++++++++++++++
> 2 files changed, 156 insertions(+)
> create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
>
> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 1bf0c472f6b4..540bb5ae746b 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,4 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> + socfpga_stratix10_socdk_emmc.dtb \
> socfpga_stratix10_socdk_nand.dtb \
> socfpga_stratix10_swvp.dtb
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
> new file mode 100644
> index 000000000000..01694920afaf
> --- /dev/null
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts
90% of this new file appears to duplicate the base device, I think that
should be extracted to a common file.
> @@ -0,0 +1,155 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright Altera Corporation (C) 2026. All rights reserved.
> + */
> +
> +#include "socfpga_stratix10.dtsi"
> +
> +/ {
> + model = "SoCFPGA Stratix 10 SoCDK eMMC daughter board";
> + compatible = "altr,socfpga-stratix10-socdk-emmc", "altr,socfpga-stratix10";
> +
> + aliases {
> + serial0 = &uart0;
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + ethernet2 = &gmac2;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + led-hps0 {
> + label = "hps_led0";
> + gpios = <&portb 20 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-hps1 {
> + label = "hps_led1";
> + gpios = <&portb 19 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-hps2 {
> + label = "hps_led2";
> + gpios = <&portb 21 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> + memory@...00000 {
> + device_type = "memory";
> + /* We expect the bootloader to fill in the reg */
> + reg = <0 0x80000000 0 0>;
> + };
> +
> + ref_033v: regulator-0v33-ref {
> + compatible = "regulator-fixed";
> + regulator-name = "0.33V";
> + regulator-min-microvolt = <330000>;
> + regulator-max-microvolt = <330000>;
> + };
> +
> + soc@0 {
> + eccmgr {
This eccmgr node already exists, you should access it by label.
> + sdmmca-ecc@...c8c00 {
> + compatible = "altr,socfpga-s10-sdmmc-ecc",
> + "altr,socfpga-sdmmc-ecc";
> + reg = <0xff8c8c00 0x100>;
> + altr,ecc-parent = <&mmc>;
> + interrupts = <14 4>,
> + <15 4>;
> + };
> + };
> + };
> +};
> +
> +&gpio1 {
> + status = "okay";
> +};
> +
> +&gmac2 {
> + status = "okay";
> + /* PHY delays is configured via skew properties */
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> +
> + max-frame-size = <9000>;
> +
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + phy0: ethernet-phy@4 {
> + reg = <4>;
> +
> + txd0-skew-ps = <0>; /* -420ps */
> + txd1-skew-ps = <0>; /* -420ps */
> + txd2-skew-ps = <0>; /* -420ps */
> + txd3-skew-ps = <0>; /* -420ps */
> + rxd0-skew-ps = <420>; /* 0ps */
> + rxd1-skew-ps = <420>; /* 0ps */
> + rxd2-skew-ps = <420>; /* 0ps */
> + rxd3-skew-ps = <420>; /* 0ps */
> + txen-skew-ps = <0>; /* -420ps */
> + txc-skew-ps = <900>; /* 0ps */
> + rxdv-skew-ps = <420>; /* 0ps */
> + rxc-skew-ps = <1680>; /* 780ps */
> + };
> + };
> +};
> +
> +&mmc {
> + status = "okay";
> + cap-mmc-highspeed;
> + broken-cd;
> + bus-width = <4>;
> + clk-phase-sd-hs = <0>, <135>;
> +};
> +
> +&osc1 {
> + clock-frequency = <25000000>;
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + disable-over-current;
> +};
> +
> +&watchdog0 {
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> + clock-frequency = <100000>;
> + i2c-sda-falling-time-ns = <890>; /* hcnt */
> + i2c-scl-falling-time-ns = <890>; /* lcnt */
> +
> + adc@14 {
> + compatible = "lltc,ltc2497";
> + reg = <0x14>;
> + vref-supply = <&ref_033v>;
> + };
> +
> + temp@4c {
> + compatible = "maxim,max1619";
> + reg = <0x4c>;
> + };
> +
> + eeprom@51 {
> + compatible = "atmel,24c32";
> + reg = <0x51>;
> + pagesize = <32>;
> + };
> +
> + rtc@68 {
> + compatible = "dallas,ds1339";
> + reg = <0x68>;
> + };
> +};
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists