linux-kernel - Re: [PATCH 2/2] serial: 8250: 8250_omap.c: Clear DMA RX running status only after DMA termination is done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0462fd91-54b8-4ceb-a623-80326e6ce658@ti.com>
Date: Tue, 20 Jan 2026 10:48:45 +0530
From: "Kumar, Udit" <u-kumar1@...com>
To: Moteen Shah <m-shah@...com>, <gregkh@...uxfoundation.org>,
	<jirislaby@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	<vigneshr@...com>, <gehariprasath@...com>, <g-praveen@...com>,
	<j-keerthy@...com>, <u-kumar1@...com>
Subject: Re: [PATCH 2/2] serial: 8250: 8250_omap.c: Clear DMA RX running
 status only after DMA termination is done

Please check subject

git log drivers/tty/serial/8250/8250_omap.c

serial: 8250_omap: ....

On 1/12/2026 1:48 PM, Moteen Shah wrote:
> Clear rx_running flag only after DMA teardown polling completes. In the
> previous implementation the flag was being cleared while hardware teardown
hardware to DMA please,
> was still in progress, creating a mismatch between software state
> (flag = 0, "ready") and hardware state (still terminating).
>
> Signed-off-by: Moteen Shah <m-shah@...com>
> ---
>   drivers/tty/serial/8250/8250_omap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index e26bae0a6488..272bc07c9a6b 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -931,7 +931,6 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
>   		goto out;
>   
>   	cookie = dma->rx_cookie;
> -	dma->rx_running = 0;
>   
>   	/* Re-enable RX FIFO interrupt now that transfer is complete */
>   	if (priv->habit & UART_HAS_RHR_IT_DIS) {
> @@ -965,6 +964,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
>   		goto out;
>   	ret = tty_insert_flip_string(tty_port, dma->rx_buf, count);
>   
> +	dma->rx_running = 0;
>   	p->port.icount.rx += ret;
>   	p->port.icount.buf_overrun += count - ret;
>   out: