linux-kernel - Re: [PATCH] x86/lib: Fix num_digits() signed overflow for INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260120212252.GHaW_yLDCAbVnl4Bk-@fat_crate.local>
Date: Tue, 20 Jan 2026 22:22:52 +0100
From: Borislav Petkov <bp@...en8.de>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: David Desobry <david.desobry@...malgen.com>, tglx@...nel.org,
	mingo@...hat.com, dave.hansen@...ux.intel.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/lib: Fix num_digits() signed overflow for INT_MIN

On Tue, Jan 20, 2026 at 12:24:07PM -0800, H. Peter Anvin wrote:
> The switch is a good improvement. I would say, though, that if we don't need
> signed input then we should just take out the minus handling code and have the
> function take an unsigned int as input.

Yah.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette