linux-kernel - Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW_soLs_ZCBDSK0k@black.igk.intel.com>
Date: Tue, 20 Jan 2026 21:59:12 +0100
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Dave Hansen <dave.hansen@...el.com>
Cc: Chao Gao <chao.gao@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	linux-kernel@...r.kernel.org, sohil.mehta@...el.com,
	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
	Ingo Molnar <mingo@...hat.com>, Jon Kohler <jon@...anix.com>,
	Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Thomas Gleixner <tglx@...nel.org>, Tony Luck <tony.luck@...el.com>,
	x86@...nel.org
Subject: Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into
 a helper

On Tue, Jan 20, 2026 at 08:06:41AM -0800, Dave Hansen wrote:
> On 1/19/26 19:07, Chao Gao wrote:

...

> >> +#include <asm/cpu.h>
> >> #include <asm/msr.h>
> >> +#include <asm/intel-family.h>
> > nit: You may want to sort the header files alphabetically.
> 
> I was probably going for christmas tree here or something. But,
> seriously, I don't think we've written down any guidance on header
> ordering for tip or in the tree in general.
> 
> It's still kinda the wild west, I think.

It was unclear why you put these two new headers in such an order.
Because it feels like you wanted something like alphabetical, but
something went differently. For the xmas tree I would expect them
still go together

#include <asm/msr.h>
#include <asm/cpu.h>
#include <asm/intel-family.h>

But personally I'm with Chao Gao, the alphabetical is easier to maintain
as it's natural order that many people got for many years starting from
kindergarten times.

-- 
With Best Regards,
Andy Shevchenko