linux-kernel - Re: [PATCH v3 3/3] spi: xilinx: use device property accessors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <817bcc43-7f10-4329-8924-6c375eb73ff2@sirena.org.uk>
Date: Tue, 20 Jan 2026 21:04:58 +0000
From: Mark Brown <broonie@...nel.org>
To: Abdurrahman Hussain <abdurrahman@...thop.ai>
Cc: Michal Simek <michal.simek@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
	linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] spi: xilinx: use device property accessors.

On Tue, Jan 20, 2026 at 11:11:44AM -0800, Abdurrahman Hussain wrote:
> > On Jan 20, 2026, at 10:45 AM, Mark Brown <broonie@...nel.org> wrote:
> > On Mon, Jan 19, 2026 at 04:20:06PM -0800, Abdurrahman Hussain wrote:

Let me once more renew my plea:

> > To repeat once again:

> > | Please fix your mail client to word wrap within paragraphs at something
> > | substantially less than 80 columns.  Doing this makes your messages much
> > | easier to read and reply to.

> > To drivers that are used on ACPI systems, yes.  Many devices wouldn't be
> > used on ACPI systems, or would be expected to be exposed differently
> > (for example, hidden behind AML).

> This is not for a normal off the shelf server. In our case we are building an embedded
> switch with an AMD CPU and Xilinx FPGAs that happens to use EDK2 based BIOS and ACPI.

Sure, AFAICT it's mostly a PCI card with a bunch of stuff on it from a
software point of view.

> >> I am just trying to get this 2-line small change merged so we can start using the standard spi-xilinx driver today. I am not trying to boil the ocean.

> > I mean, adding a HID wouldn't take substantially more code.

> We could, but we don’t own the Xilinx IP blocks. Are we not justified in using PRP0001
> hack until the driver owner adds the HIDs? Wasn’t PRP0001 created as an escape hatch for
> these kind of scenarios?

No, it's more there for the cases where embedded ACPI systems need to
import non-trivial DT bindings so they can avoid having to respecify
things that ACPI really doesn't cope with or for local hacks.  See
Andy's reply earlier in the thread:

   https://lore.kernel.org/r/aW9JihlsjnJ-uBul@black.igk.intel.com

AFAICT for ACPI the HID assigment is a bit of a free for all in practice
- board vendors generally seem perfectly happy to just pick something if
the silicon vendor didn't do something.  Just look at all the parts with
INTxxxx IDs!  That said Michal is on the thread so hopefully that's not
an issue and we can get something from Xilinx fairly easily.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)