linux-kernel - Re: [PATCH v7 2/9] s390/pci: Add architecture specific resource/bus address translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62fd96f7411db60c01de8373ee2c4909a2e9de70.camel@linux.ibm.com>
Date: Tue, 20 Jan 2026 23:15:31 +0100
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Farhan Ali <alifm@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Cc: helgaas@...nel.org, lukas@...ner.de, alex@...zbot.org, clg@...hat.com,
        stable@...r.kernel.org, mjrosato@...ux.ibm.com
Subject: Re: [PATCH v7 2/9] s390/pci: Add architecture specific
 resource/bus address translation

On Wed, 2026-01-07 at 10:32 -0800, Farhan Ali wrote:
> On s390 today we overwrite the PCI BAR resource address to either an
> artificial cookie address or MIO address. However this address is different
> from the bus address of the BARs programmed by firmware. The artificial
> cookie address was created to index into an array of function handles
> (zpci_iomap_start). The MIO (mapped I/O) addresses are provided by firmware
> but maybe different from the bus addresses. This creates an issue when trying
> to convert the BAR resource address to bus address using the generic
> pcibios_resource_to_bus().
> 
> Implement an architecture specific pcibios_resource_to_bus() function to
> correctly translate PCI BAR resource addresses to bus addresses for s390.
> Similarly add architecture specific pcibios_bus_to_resource function to do
> the reverse translation.
> 
> Reviewed-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> Signed-off-by: Farhan Ali <alifm@...ux.ibm.com>
> ---

My R-b stands but I'd like to add that checkpatch.pl with "--strict"
notes that your commit description is not properly wrapped at 75
characters. Furthermore it reports the following code alignment issues:

CHECK: Alignment should match open parenthesis
#125: FILE: drivers/pci/host-bridge.c:53:
+void __weak pcibios_resource_to_bus(struct pci_bus *bus, struct pci_bus_region *region,
                             struct resource *res)

CHECK: Alignment should match open parenthesis
#134: FILE: drivers/pci/host-bridge.c:78:
+void __weak pcibios_bus_to_resource(struct pci_bus *bus, struct resource *res,
                             struct pci_bus_region *region)

Thanks,
Niklas