linux-kernel - Re: [PATCH v3 5/5] firmware: dmi: Read additional information when decoding DMI table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260120220534.GA1775505@yaz-khff2.amd.com>
Date: Tue, 20 Jan 2026 17:05:34 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Mario Limonciello <superm1@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v3 5/5] firmware: dmi: Read additional information when
 decoding DMI table

On Tue, Jan 20, 2026 at 03:55:54PM -0600, Mario Limonciello wrote:
> On 1/20/26 3:45 PM, Yazen Ghannam wrote:
> > On Fri, Jan 16, 2026 at 04:30:32PM -0500, Yazen Ghannam wrote:
> > > On Sat, Jan 10, 2026 at 07:48:34AM -0600, Mario Limonciello (AMD) wrote:
> > > 
> > 
> > [...]
> > 
> > > ACPI tables do this a lot. So there are examples of iterating over
> > > variable length entries.
> > 
> > Here's another implementation. What do you think?
> 
> Oh you beat me to it, been busy this week.
> 
> I do like that we can localize the printing code to amd.c.  I'll test it and
> let you know if it works.
> 
> If it does; I'll roll it into the series.
> 

Good deal, thanks!

[...]

> > +
> > +		string_ptr = dmi_string_nosave(&info->header, entry->str_num);
> > +
> > +		/* Only one AGESA string is expected. */
> > +		if (!strncmp(string_ptr, "AGESA", 5)) {
> > +			pr_info("%s\n", string_ptr);
> > +			break;
> > +		}
> > +

[...]

> > +static inline const char *
> > +	dmi_string_nosave(const struct dmi_header *dm, u8 s) { return NULL; }

Found a bug. :/

The default return value should be "dmi_empty_string".

Thanks,
Yazen