linux-kernel - Re: [PATCH 0/4] tools/docs: sphinx-build-wrapper: avoid spurious rust docs generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260120234317.48887b52@foz.lan>
Date: Tue, 20 Jan 2026 23:43:17 +0100
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Jonathan Corbet
 <corbet@....net>, Shuah Khan <skhan@...uxfoundation.org>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] tools/docs: sphinx-build-wrapper: avoid spurious
 rust docs generation

On Sun, 18 Jan 2026 00:26:20 +0100
Thomas Weißschuh <linux@...ssschuh.net> wrote:

> Currently the rust docs are generated for each entry of SPHINXDIRS,
> even those not mentioning the rust directory.
> 
> Only generate the rust docs only once and only when requested.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> Thomas Weißschuh (4):
>       tools/docs: sphinx-build-wrapper: generate rust docs only once
>       tools/docs: sphinx-build-wrapper: make 'rustdoc' a local variable
>       tools/docs: sphinx-build-wrapper: compute sphinxdirs_list earlier
>       tools/docs: sphinx-build-wrapper: only generate rust docs when requested
> 
>  tools/docs/sphinx-build-wrapper | 80 +++++++++++++++++++++--------------------
>  1 file changed, 41 insertions(+), 39 deletions(-)

Patches in this series look ok. Code reviewed and I also did some
tests, and all LGTM.

So, for this series:

[mchehab: tested building with and without config RUST, doing
 a full build and also passing --sphinxdirs rust peci and just
 --sphinxdirs rust]

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Tested-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Thanks,
Mauro