lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202601210634.oa0j58TO-lkp@intel.com>
Date: Wed, 21 Jan 2026 06:56:19 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Len Brown <lenb@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] ACPI: video: simplify code with
 acpi_get_local_u64_address()

Hi Andy,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.19-rc6 next-20260120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ACPI-video-simplify-code-with-acpi_get_local_u64_address/20260121-015338
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20260120154008.1763983-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] ACPI: video: simplify code with acpi_get_local_u64_address()
config: i386-defconfig (https://download.01.org/0day-ci/archive/20260121/202601210634.oa0j58TO-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260121/202601210634.oa0j58TO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601210634.oa0j58TO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/acpi_video.c:1137:14: warning: unused variable 'status' [-Wunused-variable]
    1137 |         acpi_status status;
         |                     ^~~~~~
   1 warning generated.


vim +/status +1137 drivers/acpi/acpi_video.c

e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1131  
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1132  static int acpi_video_bus_get_one_device(struct acpi_device *device, void *arg)
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1133  {
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1134  	struct acpi_video_bus *video = arg;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1135  	struct acpi_video_device_attrib *attribute;
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1136  	struct acpi_video_device *data;
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13 @1137  	acpi_status status;
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1138  	int device_type;
6a9c39632cf1cd drivers/acpi/acpi_video.c Andy Shevchenko             2026-01-20  1139  	u64 device_id;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1140  
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1141  	/* Skip devices without _ADR instead of failing. */
6a9c39632cf1cd drivers/acpi/acpi_video.c Andy Shevchenko             2026-01-20  1142  	if (acpi_get_local_u64_address(device->handle, &device_id))
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1143  		goto exit;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1144  
36bcbec7ce21e2 drivers/acpi/video.c      Burman Yan                  2006-12-19  1145  	data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1146  	if (!data) {
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1147  		dev_dbg(&device->dev, "Cannot attach\n");
d550d98d331737 drivers/acpi/video.c      Patrick Mochel              2006-06-27  1148  		return -ENOMEM;
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1149  	}
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1150  
cfc38d432dba56 drivers/acpi/acpi_video.c Muhammad Qasim Abdul Majeed 2024-07-03  1151  	strscpy(acpi_device_name(device), ACPI_VIDEO_DEVICE_NAME);
cfc38d432dba56 drivers/acpi/acpi_video.c Muhammad Qasim Abdul Majeed 2024-07-03  1152  	strscpy(acpi_device_class(device), ACPI_VIDEO_CLASS);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1153  
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1154  	data->device_id = device_id;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1155  	data->video = video;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1156  	data->dev = device;
8ab58e8e7e097b drivers/acpi/video.c      Linus Torvalds              2014-07-18  1157  	INIT_DELAYED_WORK(&data->switch_brightness_work,
8ab58e8e7e097b drivers/acpi/video.c      Linus Torvalds              2014-07-18  1158  			  acpi_video_switch_brightness);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1159  
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1160  	attribute = acpi_video_get_device_attr(video, device_id);
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1161  
e50b9be14ab0ed drivers/acpi/acpi_video.c Aaron Lu                    2015-10-28  1162  	if (attribute && (attribute->device_id_scheme || device_id_scheme)) {
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1163  		switch (attribute->display_type) {
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1164  		case ACPI_VIDEO_DISPLAY_CRT:
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1165  			data->flags.crt = 1;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1166  			break;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1167  		case ACPI_VIDEO_DISPLAY_TV:
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1168  			data->flags.tvout = 1;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1169  			break;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1170  		case ACPI_VIDEO_DISPLAY_DVI:
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1171  			data->flags.dvi = 1;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1172  			break;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1173  		case ACPI_VIDEO_DISPLAY_LCD:
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1174  			data->flags.lcd = 1;
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1175  			break;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1176  		default:
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1177  			data->flags.unknown = 1;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1178  			break;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1179  		}
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1180  		if (attribute->bios_can_detect)
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1181  			data->flags.bios = 1;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1182  	} else {
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1183  		/* Check for legacy IDs */
91e13aa3702343 drivers/acpi/video.c      Aaron Lu                    2013-04-25  1184  		device_type = acpi_video_get_device_type(video, device_id);
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1185  		/* Ignore bits 16 and 18-20 */
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1186  		switch (device_type & 0xffe2ffff) {
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1187  		case ACPI_VIDEO_DISPLAY_LEGACY_MONITOR:
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1188  			data->flags.crt = 1;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1189  			break;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1190  		case ACPI_VIDEO_DISPLAY_LEGACY_PANEL:
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1191  			data->flags.lcd = 1;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1192  			break;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1193  		case ACPI_VIDEO_DISPLAY_LEGACY_TV:
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1194  			data->flags.tvout = 1;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1195  			break;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1196  		default:
82cae99980c158 drivers/acpi/video.c      Rui Zhang                   2007-01-03  1197  			data->flags.unknown = 1;
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1198  		}
e92a7162402589 drivers/acpi/video.c      Matthew Garrett             2010-01-12  1199  	}
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1200  
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1201  	acpi_video_device_bind(video, data);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1202  	acpi_video_device_find_cap(data);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1203  
3a0cf7ab8df387 drivers/acpi/acpi_video.c Hans de Goede               2022-06-24  1204  	if (data->cap._BCM && data->cap._BCL)
5ad26161a371e4 drivers/acpi/acpi_video.c Hans de Goede               2022-07-13  1205  		may_report_brightness_keys = true;
3a0cf7ab8df387 drivers/acpi/acpi_video.c Hans de Goede               2022-06-24  1206  
bbac81f5487175 drivers/acpi/video.c      Dmitry Torokhov             2007-11-05  1207  	mutex_lock(&video->device_list_lock);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1208  	list_add_tail(&data->entry, &video->video_device_list);
bbac81f5487175 drivers/acpi/video.c      Dmitry Torokhov             2007-11-05  1209  	mutex_unlock(&video->device_list_lock);
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1210  
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1211  exit:
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1212  	video->child_count++;
0ea3ef240c4911 drivers/acpi/acpi_video.c Rafael J. Wysocki           2022-06-13  1213  	return 0;
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1214  }
^1da177e4c3f41 drivers/acpi/video.c      Linus Torvalds              2005-04-16  1215  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ