linux-kernel - Re: Since 6.18.x make binrpm-pkg does not sign modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd25c77c-94c9-7095-441c-b15939a0b4af@diagnostix.dwd.de>
Date: Wed, 21 Jan 2026 00:21:04 +0100 (CET)
From: Holger Kiehl <Holger.Kiehl@....de>
To: Nathan Chancellor <nathan@...nel.org>
cc: Nicolas Schier <nsc@...nel.org>, 
    linux-kernel <linux-kernel@...r.kernel.org>, linux-kbuild@...r.kernel.org, 
    Uday Shankar <ushankar@...estorage.com>
Subject: Re: Since 6.18.x make binrpm-pkg does not sign modules

On Mon, 19 Jan 2026, Nathan Chancellor wrote:

> On Sun, Jan 11, 2026 at 06:41:39PM +0100, Holger Kiehl wrote:
> > On Sat, 10 Jan 2026, Nicolas Schier wrote:
> > 
> > > A simple solution might be to call modules_sign target after the
> > > find-debuginfo.sh run; but commit 16c36f8864e3 spunds to me as if we
> > > should rather do something similiar as for the Debian packages:
> > > modules_install with INSTALL_MOD_STRIP=1 and then install only the debug
> > > infos manually.
> > > 
> > > Does that make sense?
> > > 
> > I am not a kernel developer and my knowledge in this area is very
> > limited. Did try your suggestion to call modules_install with
> > INSTALL_MOD_STRIP=1, but still the signature was removed in the
> > RPM. Removing the 'chmod u+x', so find-debuginfo.sh does not strip
> > them, did not help either. But, most properly, I am still missing
> > something.
> 
> I think one of the items added to __spec_install_post by commit
> a7c699d090a1 ("kbuild: rpm-pkg: build a debuginfo RPM") ends up
> stripping the modules unconditionally, not just when the debuginfo
> package is built, as this reproduces for me with your configuration
> snippet from upthread and x86_64_defconfig, which does not have debug
> information enabled.
> 
> I emulated commit 16c36f8864e3 ("kbuild: deb-pkg: use build ID instead
> of debug link for dbg package") for rpm-pkg, which appears to result in
> a functionally equivalent standalone debuginfo package (but I did not
> actually test) while fixing module signing for me. Could you give it a
> test?
>
Thanks for the patch! Can confirm with the patch applied, the modules
are now signed in the rpm package. But I also did not test the debuginfo
part.

Regards,
Holger