[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <rsxdnmh4ezutvsblmcvjcwtwyuyrlrndxcyec3kth6ccqyxeac@yzcp2g6bqota>
Date: Tue, 20 Jan 2026 09:45:33 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
Cc: Georgi Djakov <djakov@...nel.org>,
Odelu Kukatla <odelu.kukatla@....qualcomm.com>,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] interconnect: qcom: qcs8300: fix the num_links for
nsp icc node
On Tue, Jan 20, 2026 at 06:57:14AM +0000, Raviteja Laggyshetty wrote:
> Update the num_links to 2 for qxm_nsp node, this will help the clients
> to get the required path handle to vote on qxm_nsp->ebi path.
- Please describe the issue
- Please describe how it should be solved.
Having the link doesn't "help the clients". It allows them to cast votes
on certain BW paths.
>
> Fixes: 874be3339c85 ("interconnect: qcom: qcs8300: convert to dynamic IDs")
> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
> ---
> Changes in v2:
> - Corrected the commit ID mentioned in Fixes tag.
> - Link to v1: https://lore.kernel.org/r/20260120-monaco_num_links_fix_nsp_ebi_path-v1-1-4aa2662637a3@oss.qualcomm.com
> ---
> drivers/interconnect/qcom/qcs8300.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/qcs8300.c b/drivers/interconnect/qcom/qcs8300.c
> index 70a377bbcf2930a4bdddcf6c3d98e95e4ad92561..bc403a9bf68c65c5e5b312505933f58c5bbeaaf7 100644
> --- a/drivers/interconnect/qcom/qcs8300.c
> +++ b/drivers/interconnect/qcom/qcs8300.c
> @@ -629,7 +629,7 @@ static struct qcom_icc_node qxm_nsp = {
> .name = "qxm_nsp",
> .channels = 2,
> .buswidth = 32,
> - .num_links = 1,
> + .num_links = 2,
> .link_nodes = { &qns_hcp, &qns_nsp_gemnoc },
> };
>
>
> ---
> base-commit: f417b7ffcbef7d76b0d8860518f50dae0e7e5eda
> change-id: 20260119-monaco_num_links_fix_nsp_ebi_path-a658f8fc100f
>
> Best regards,
> --
> Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists