linux-kernel - Re: [PATCH v2 10/10] dt-bindings: mtd: partitions: Combine simple partition bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260120-origami-lori-of-genius-8fd944@quoll>
Date: Tue, 20 Jan 2026 10:04:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Brian Norris <computersforpeace@...il.com>, Kamal Dasu <kdasu.kdev@...il.com>, 
	William Zhang <william.zhang@...adcom.com>, Nick Terrell <terrelln@...com>, David Sterba <dsterba@...e.com>, 
	Rafał Miłecki <rafal@...ecki.pl>, Simon Glass <sjg@...omium.org>, 
	Linus Walleij <linusw@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Marcus Folkesson <marcus.folkesson@...il.com>, Tony Lindgren <tony@...mide.com>, 
	Roger Quadros <rogerq@...nel.org>, Hauke Mehrtens <hauke@...ke-m.de>, linux-mtd@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2 10/10] dt-bindings: mtd: partitions: Combine simple
 partition bindings

On Mon, Jan 19, 2026 at 07:48:31PM -0600, Rob Herring (Arm) wrote:
> Several partition node bindings are just a compatible plus properties
> defined in partition.yaml. Move all of these bindings to a single schema
> file.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> -        partition@...000 {
> -            compatible = "tfa-bl31";
> -            reg = <0x200000 0x100000>;
> -            align = <0x4000>;
> -        };
> -    };
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm4908-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm4908-partitions.yaml
> index 159b32d12803..a6edf145df57 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm4908-partitions.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/brcm,bcm4908-partitions.yaml
> @@ -29,11 +29,7 @@ properties:
>  
>  patternProperties:
>    "^partition@[0-9a-f]+$":
> -    $ref: partition.yaml#
> -    properties:
> -      compatible:
> -        const: brcm,bcm4908-firmware
> -    unevaluatedProperties: false
> +    type: object

I think this is not specific enough now and you should have here $ref
(e.g. to simple-partition.yaml) with unevaluatedProperties. Otherwise
schema does not report:
1. bogus properties in partition@ nodes without compatibles (like the
   first one in the example),
2. partition@ nodes with some other compatibles (non-partition like,
   e.g. whatever I2C device stuffed there for which there is a schema of
   course)

Best regards,
Krzysztof