linux-kernel - Re: [PATCH 22/26] rv/rvgen: remove unused __get_main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa8dc8a894db0d78115ee366af79db196f56c0ff.camel@redhat.com>
Date: Tue, 20 Jan 2026 10:08:51 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, 
 open list <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION
 (RV)"	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 22/26] rv/rvgen: remove unused __get_main_name method

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> The __get_main_name() method in the generator module is never called
> from anywhere in the codebase. Remove this dead code to improve
> maintainability.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Good catch, thanks!

Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>

> ---
>  tools/verification/rvgen/rvgen/generator.py | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/verification/rvgen/rvgen/generator.py
> b/tools/verification/rvgen/rvgen/generator.py
> index 0491f8c9cb0b9..d99a980850d64 100644
> --- a/tools/verification/rvgen/rvgen/generator.py
> +++ b/tools/verification/rvgen/rvgen/generator.py
> @@ -206,12 +206,6 @@ obj-$(CONFIG_RV_MON_{name_up}) +=
> monitors/{name}/{name}.o
>              path = os.path.join(self.rv_dir, "monitors", path)
>          self.__write_file(path, content)
>  
> -    def __get_main_name(self):
> -        path = f"{self.name}/main.c"
> -        if not os.path.exists(path):
> -            return "main.c"
> -        return "__main.c"
> -
>      def print_files(self):
>          main_c = self.fill_main_c()
>