linux-kernel - Re: [PATCH 21/26] rv/rvgen: remove unused sys import from dot2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <071f940ebd428349862fcf233130d5f9774512a5.camel@redhat.com>
Date: Tue, 20 Jan 2026 10:16:07 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, 
 open list <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION
 (RV)"	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 21/26] rv/rvgen: remove unused sys import from dot2c

On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
> The sys module was imported in the dot2c frontend script but never
> used. This import was likely left over from earlier development or
> copied from a template that required sys for exit handling.
> 
> Remove the unused import to clean up the code and satisfy linters
> that flag unused imports as errors.
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Good catch, thanks!

Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>

> ---
>  tools/verification/rvgen/dot2c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/verification/rvgen/dot2c b/tools/verification/rvgen/dot2c
> index bf0c67c5b66c8..1012becc7fab6 100644
> --- a/tools/verification/rvgen/dot2c
> +++ b/tools/verification/rvgen/dot2c
> @@ -16,7 +16,6 @@
>  if __name__ == '__main__':
>      from rvgen import dot2c
>      import argparse
> -    import sys
>  
>      parser = argparse.ArgumentParser(description='dot2c: converts a .dot file
> into a C structure')
>      parser.add_argument('dot_file',  help='The dot file to be converted')