linux-kernel - Re: [PATCH v7 3/7] media: platform: amd: Add isp4 fw and hw interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b95118d9-7186-4ec8-8760-ecf6345ce875@amd.com>
Date: Tue, 20 Jan 2026 17:22:41 +0800
From: "Du, Bin" <bin.du@....com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl,
 laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
 prabhakar.mahadev-lad.rj@...renesas.com, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, sultan@...neltoast.com,
 pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
 gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
 mario.limonciello@....com, richard.gong@....com, anson.tsao@....com,
 Alexey Zagorodnikov <xglooom@...il.com>
Subject: Re: [PATCH v7 3/7] media: platform: amd: Add isp4 fw and hw interface

Hi Sakari, there's still one left. Could you please help check it?

On 1/7/2026 4:44 PM, Du, Bin wrote:
> Thank you, Sakari for the feedback.
> 
> On 12/22/2025 5:37 PM, Sakari Ailus wrote:
>> Hi Bin,
>>
>> On Tue, Dec 16, 2025 at 05:13:22PM +0800, Bin Du wrote:

[snip]

>>> +enum isp4fw_buffer_source {
>>> +    /* The buffer is from the stream buffer queue */
>>> +    BUFFER_SOURCE_STREAM,
>>> +};
>>
>> Could you also use the ISP4 (or ISP4IF) prefix for these, please? Many 
>> look
>> rather generic.
>>
> 
> Thank you for highlighting this matter, since these definitions are 
> located in isp4_fw_cmd_resp.h, ISP4_FW may be a more appropriate prefix. 
> Just to confirm: are you suggesting that we should add this prefix to 
> all macros and enums? For example, changing CMD_ID_SET_STREAM_CONFIG to 
> ISP4_FW_CMD_ID_SET_STREAM_CONFIG, and BUFFER_SOURCE_STREAM to ISP4_FW 
> _BUFFER_SOURCE_STREAM? Our initial thought was that these would only be 
> used within ISP and shouldn't lead to any confusion.
> 

Hi Sakari, would you please help to confirm so we can decide if further 
modification is needed.

[snip]

-- 
Regards,
Bin