[<prev] [next>] [day] [month] [year] [list]
Message-ID: <ahytfwrx6d7nvddjviqt6wyit6f7flh5vmiuuzdet44unjdbwp@cktsraaj56au>
Date: Tue, 20 Jan 2026 10:32:26 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
Michal Wilczynski <m.wilczynski@...sung.com>, Richard Genoud <richard.genoud@...tlin.com>
Subject: [GIT PULL] pwm: Two fixes and a maintainer update
Hello Linus,
the following changes since commit 8f0b4cce4481fb22653697cced8d0d04027cb1e8:
Linux 6.19-rc1 (2025-12-14 16:05:07 +1200)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git tags/pwm/for-6.19-rc7-fixes
for you to fetch changes up to 0a155a8a24ddc647aaf28ce7cdb14af7270c158f:
MAINTAINERS: Add myself as reviewer for PWM rust drivers (2026-01-20 09:53:18 +0100)
The commit that triggered this pull request is the ioctl one that I
consider critical to get in. I only noticed this problem recently, so
it's not in next yet, but it should be obvious and simple enough to be
correct.
I wouldn't have bothered you for the other two changes alone, but sent
them along now that there is a fixes PR. These are both not very
critical, but also simple enough to not have to fear regressions. The
max7360 commit also sat in next since next-20260116 with a different
commit id (i.e. 3bbf529821f64cebad9f385af19e149a9dfffead) as I initially
thought to not send it to you and now had to rebase it to not include
merge window material. The other patch is just an update to MAINTAINERS
to prevent people sending rust pwm patches without cc:ing Michal.
Thanks for pulling this for 6.19-rc7.
Best regards from Germany
Uwe
----------------------------------------------------------------
pwm: Two fixes and a maintainer update
Included here are three changes:
- pwm: Ensure ioctl() returns a negative errno on error
This affects two ioctls on /dev/pwmchipX where the return value of
copy_to_user() was passed to userspace. This is fixed to return
-EFAULT now instead.
You might argue that this is an ABI change, but I still think it's
sensible to be fixed because a) other exit paths already return
-EFAULT so userspace must be aware of this return value; b) the
interface is somewhat new (commit v6.17-rc1~181^2~35 ("pwm: Add
support for pwmchip devices for faster and easier userspace access"))
and the only known user is libpwm which relies on the fixed
semantics (and uses the ioctl correctly and thus doesn't trigger that
problematic error path); and c) it's very unlikely that
copy_to_user() fails if a moment before copy_from_user() on the same
memory chunk succeeded.
- pwm: max7360: Populate missing .sizeof_wfhw in max7360_pwm_ops
This fixes an oversight in commit v6.18-rc1~168^2~3^2~6 which added
support for the max7360 driver. There is no user-visible effect
because the .sizeof_wfhw member is just a safe guard that the memory
provided by the core is big enough. While it currently is big enough
and there is no reason to assume that will change, doing that
correctly is necessary.
- MAINTAINERS: Add myself as reviewer for PWM rust drivers
"Myself" here is Michal Wilczynski who cares for the Rust parts of
the pwm subsystem. Several of the patches sent recently for the (for
now) only Rust pwm driver did not add Michal to Cc which resulted in
the patches waiting for review as I thought Michal would care but he
wasn't aware of them.
----------------------------------------------------------------
Michal Wilczynski (1):
MAINTAINERS: Add myself as reviewer for PWM rust drivers
Richard Genoud (1):
pwm: max7360: Populate missing .sizeof_wfhw in max7360_pwm_ops
Uwe Kleine-König (1):
pwm: Ensure ioctl() returns a negative errno on error
MAINTAINERS | 4 ++++
drivers/pwm/core.c | 10 ++++++----
drivers/pwm/pwm-max7360.c | 1 +
3 files changed, 11 insertions(+), 4 deletions(-)
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists