linux-kernel - Re: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add support for rotation sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aW9MhYO_xhlQXFn2@smile.fi.intel.com>
Date: Tue, 20 Jan 2026 11:36:05 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Francesco Lavra <flavra@...libre.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add support for rotation
 sensor

On Tue, Jan 20, 2026 at 10:28:15AM +0100, Francesco Lavra wrote:
> On Mon, 2026-01-19 at 12:33 +0200, Andy Shevchenko wrote:
> > On Mon, Jan 19, 2026 at 11:04:49AM +0100, Francesco Lavra wrote:

...

> > > +       snprintf(sensor->name, sizeof(sensor->name), "%s_sf", name);
> > 
> > Does GCC complain on this (`make W=1` build)?
> > Since this can cut the string and we don't check the return value, the Q
> > is:
> > is this okay to have a reduced string?
> 
> gcc does not complain with W=1. sensor->name is appropriately sized to
> accommodate the longest possible name; if it wasn't, the string would be
> cut in the accel and gyro IIO devices too (which use a longer suffix than
> "_sf").

Right, the question is if compiler can prove that or not.

We have several patches in input subsystem to hide the warning by switching
to scnprintf(), which I consider not the best approach, but still it depends
if we care about cut or not. If we do, we should check for overflow.

-- 
With Best Regards,
Andy Shevchenko