linux-kernel - Re: [PATCH v3 1/2] drm/panel: simple: Add Waveshare 13.3" panel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXa=NSu788E5G-aY4CA3hrM8s8fO9ABpEN_wy+5A=JHNg@mail.gmail.com>
Date: Tue, 20 Jan 2026 10:33:14 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Marek Vasut <marek.vasut@...lbox.org>
Cc: dri-devel@...ts.freedesktop.org, Conor Dooley <conor+dt@...nel.org>, 
	David Airlie <airlied@...il.com>, Jessica Zhang <jesszhan0024@...il.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Magnus Damm <magnus.damm@...il.com>, Maxime Ripard <mripard@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Rob Herring <robh@...nel.org>, 
	Sam Ravnborg <sam@...nborg.org>, Simona Vetter <simona@...ll.ch>, 
	Thierry Reding <thierry.reding@...il.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] drm/panel: simple: Add Waveshare 13.3" panel support

Hi Marek,

On Mon, 19 Jan 2026 at 20:08, Marek Vasut <marek.vasut@...lbox.org> wrote:
> On 1/19/26 4:56 PM, Geert Uytterhoeven wrote:
> >> --- a/drivers/gpu/drm/panel/panel-simple.c
> >> +++ b/drivers/gpu/drm/panel/panel-simple.c
> >> @@ -4998,6 +4998,33 @@ static const struct panel_desc vl050_8048nt_c01 = {
> >>          .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> >>   };
> >>
> >> +static const struct drm_display_mode waveshare_133inch_mode = {
> >> +       .clock = 148500,
> >> +       .hdisplay = 1920,
> >> +       .hsync_start = 1920 + 88,
> >> +       .hsync_end = 1920 + 88 + 44,
> >> +       .htotal = 1920 + 88 + 44 + 148,
> >> +       .vdisplay = 1080,
> >> +       .vsync_start = 1080 + 4,
> >> +       .vsync_end = 1080 + 4 + 5,
> >> +       .vtotal = 1080 + 4 + 5 + 36,
> >> +       .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
> >> +};
> >
> > That looks like the plain standard 60Hz Full HD mode.
> > Is there really no other copy of that structure available in the kernel?
> >
> > auo_t215hvn01_mode is almost the same, except for .clock and .flags.
> > drivers/video/fbdev/core/modedb.c has the same mode, but in a different
> > structure.
>
> The panel-simple.c is full of similar-ish panel timings . The timings
> above are adapted from the waveshare DTO for this panel. What else would
> you suggest I do/use for this device ?

I am just wondering if there is a better way for panels that use
standard timings.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds