linux-kernel - Re: [PATCH] arm64: dts: qcom: kodiak: Add missing clock votes for lpass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5976946.DvuYhMxLoT@antlia>
Date: Tue, 20 Jan 2026 16:23:09 +0530
From: Bhushan Shah <bhushan.shah@...hinesoul.in>
To: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 cros-qcom-dts-watchers@...omium.org,
 Bharadwaj Raju <bharadwaj.raju@...hinesoul.in>,
 Alexandre Ferrieux <alexandre.ferrieux@...nge.com>,
 Luca Weiss <luca.weiss@...rphone.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH] arm64: dts: qcom: kodiak: Add missing clock votes for lpass_tlmm

On Friday, 9 January 2026 21:08:32 IST Bhushan Shah wrote:
> On Friday, 9 January 2026 20:44:34 IST Luca Weiss wrote:
> > Without the correct clock votes set, we may be hitting a synchronous
> > external abort error when touching the lpi registers.
> > 
> >   Internal error: synchronous external abort: 0000000096000010 [#1]  SMP
> >   <...>
> >   
> >   Call trace:
> >    lpi_gpio_read.isra.0+0x2c/0x58 (P)
> >    pinmux_enable_setting+0x218/0x300
> >    pinctrl_commit_state+0xb0/0x280
> >    pinctrl_select_state+0x28/0x48
> >    pinctrl_bind_pins+0x1f4/0x2a0
> >    really_probe+0x64/0x3a8
> > 
> > Add the clocks to fix that.
> > 
> > Platforms with this SoC using AudioReach won't be impacted due to
> > qcs6490-audioreach.dtsi already setting clocks & clock-names for
> > q6prmcc. The sc7280-chrome-common.dtsi has also been adjusted to keep
> > the behavior the same as they also do not use Elite with q6afecc.
> > 
> > Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> 
> Tested-by: Bhushan Shah <bhushan.shah@...hinesoul.in> # On fairphone-fp5

As a follow-up;

While this fixes original abort, it seems on some coldboots or as such(?); it fails
to vote the clocks and then eventually soundcard fails to probe, so there is still
some issue that needs to be solved.

[   17.944296] Bluetooth: hci0: Frame reassembly failed (-84)
[   20.961100] qcom-q6afe aprsvc:service:4:4: AFE failed to vote (3)
[   20.961131] Failed to prepare clk 'core': -110                                                                                           
[   20.961137] qcom-sc7280-lpass-lpi-pinctrl 33c0000.pinctrl: error -ETIMEDOUT: Can't enable clocks
[   20.961144] qcom-sc7280-lpass-lpi-pinctrl 33c0000.pinctrl: probe with driver qcom-sc7280-lpass-lpi-pinctrl failed with error -110

So far I was not able to find a precise pattern to this, but doing bunch of coldboots
is most easiest way to reproduce I have found.

If anyone has any inputs on this, I would love to hear.

Best Regards,
Bhushan