linux-kernel - Re: [PATCH 3/3] sdm845: tama: Add AMS TCS3400 ambient light sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c4b38a2-d526-4ac8-95ac-f4cc828d823d@oss.qualcomm.com>
Date: Tue, 20 Jan 2026 12:06:44 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: petr.hodina@...tonmail.com, Jonathan Cameron <jic23@...nel.org>,
        David Lechner <dlechner@...libre.com>,
        Nuno Sá
 <nuno.sa@...log.com>,
        Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        David Heidelberg <david@...t.cz>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 3/3] sdm845: tama: Add AMS TCS3400 ambient light sensor

On 1/19/26 6:19 PM, Petr Hodina via B4 Relay wrote:
> From: Petr Hodina <petr.hodina@...tonmail.com>
> 
> Add device tree node for TCS3400 ambient light sensor with
> power supplies, interrupt on GPIO11, and pinctrl states.
> 
> Signed-off-by: Petr Hodina <petr.hodina@...tonmail.com>
> ---
>  .../boot/dts/qcom/sdm845-sony-xperia-tama.dtsi     | 36 +++++++++++++++++++++-
>  1 file changed, 35 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> index 7dc9349eedfd..15d56d6831c5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> @@ -485,7 +485,23 @@ &i2c14 {
>  	clock-frequency = <400000>;
>  
>  	/* SONY ToF sensor @ 52 */
> -	/* AMS TCS3490 RGB+IR color sensor @ 72 */
> +
> +	tcs3400_sensor: tcs3400_sensor@39 {

node names (between ':' and '@') must not contain underscores,
and should be generic where possible, let's call it sensor@,
rgb-ir@ or perhaps colorimeter@ (Krzysztof, opinions?)

> +		compatible = "ams,tcs3400";
> +		reg = <0x39>;

I can't find supporting evidence for this reg change

> +
> +		interrupts-extended = <&tlmm 11 IRQ_TYPE_EDGE_FALLING>;
> +
> +		vdd-supply = <&vreg_l22a_2p8>;
> +		vio-supply = <&cam_vio_vreg>;
> +
> +		pinctrl-0 = <&ams_sensor_default>;
> +		pinctrl-1 = <&ams_sensor_sleep>;
> +
> +		ams,rgbcir-vdd-supply = <1>;
> +		ams,rgbcir-gpio-vdd = <0>;
> +		ams,rgbcir-vio-supply = <1>;
> +	};
>  };
>  
>  &ibb {
> @@ -751,6 +767,24 @@ int-pins {
>  			bias-pull-down;
>  		};
>  	};
> +
> +	ams_sensor_default: ams-sensor-default-state {
> +		int-pins {

Drop this inner level, define the properties directly under the
-state node, both cases

Konrad