linux-kernel - Re: [PATCH v3 0/3] Support FT3518 touchscreen in xiaomi-laurel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176887409321.799867.15185739103671631449.robh@kernel.org>
Date: Mon, 19 Jan 2026 19:57:48 -0600
From: Rob Herring <robh@...nel.org>
To: Yedaya Katsman <yedaya.ka@...il.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-input@...r.kernel.org, 
 Bjorn Andersson <andersson@...nel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>, 
 devicetree@...r.kernel.org, 
 Kamil Gołda <kamil.golda@...tonmail.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Dmitry Torokhov <dmitry.torokhov@...il.com>, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH v3 0/3] Support FT3518 touchscreen in xiaomi-laurel


On Sun, 18 Jan 2026 22:29:39 +0200, Yedaya Katsman wrote:
> Adds support for the touchscreen in the Xiaomi Mi A3 (xiaomi-laurel)
>  smartphone, FocalTech FT3518
> 
> Original tree was here:
>  Link: https://gitlab.postmarketos.org/SzczurekYT/linux/-/commits/laurel
> 
> Signed-off-by: Yedaya Katsman <yedaya.ka@...il.com>
> ---
> Changes in v3:
> - Rename regulator node and reorder nodes
> - Add gpio pin configuration for pmx_ts_* in sm6125, and reference in the
>   touchscreen configuration as pinctrl-*. Doesn't have configuration for
>   the gpio 83 pin since it isn't documented downstream.
> - Link to v2: https://lore.kernel.org/r/20260114-touchscreen-patches-v2-0-4215f94c8aba@gmail.com
> 
> Changes in v2:
> - Fixed name and email in signoffs
> - Link to v1: https://lore.kernel.org/r/20260113-touchscreen-patches-v1-0-a10957f32dd8@gmail.com
> 
> ---
> Yedaya Katsman (3):
>       dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518
>       drivers: input: touchscreen: edt-ft5x06: Add FocalTech FT3518
>       arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen
> 
>  .../bindings/input/touchscreen/edt-ft5x06.yaml     |   1 +
>  .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts  | 113 +++++++++++++++++++++
>  drivers/input/touchscreen/edt-ft5x06.c             |   6 ++
>  3 files changed, 120 insertions(+)
> ---
> base-commit: b71e635feefc852405b14620a7fc58c4c80c0f73
> change-id: 20260113-touchscreen-patches-beb2526bd5fb
> 
> Best regards,
> --
> Yedaya Katsman <yedaya.ka@...il.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: b71e635feefc852405b14620a7fc58c4c80c0f73 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)


Warnings in base: 429
Warnings after series: 431

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260118-touchscreen-patches-v3-0-1c6a729c5eb4@...il.com:

arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dtb: pinctrl@...000 (qcom,sm6125-tlmm): Unevaluated properties are not allowed ('pmx_ts_int_active', 'pmx_ts_int_suspend', 'pmx_ts_release', 'pmx_ts_reset_active', 'pmx_ts_reset_suspend' were unexpected)
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sm6125-tlmm.yaml