linux-kernel - Re: [PATCH v3 1/2] media: i2c: imx412: fix sensor power-on timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81b142d6-7d81-47cd-85ab-c34851f4029f@oss.qualcomm.com>
Date: Tue, 20 Jan 2026 10:14:53 +0800
From: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] media: i2c: imx412: fix sensor power-on timing

Hi Sakari,

On 1/19/2026 7:35 PM, Sakari Ailus wrote:
> Hi Wenmeng,
> 
> On Mon, Jan 19, 2026 at 06:15:01PM +0800, Wenmeng Liu wrote:
>> Assert the reset GPIO at the start of power-on, enable regulators and the
>> clock, then deassert reset. This avoids a mismatch where the first
>> power-up (when the reset GPIO defaults deasserted) differs from subsequent
>> cycles.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
>> ---
>>   drivers/media/i2c/imx412.c | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
>> index b3826f80354703b17b416dc233854da3f5736e38..ebc2fb706442365f541540bf4ce9d307d42e0061 100644
>> --- a/drivers/media/i2c/imx412.c
>> +++ b/drivers/media/i2c/imx412.c
>> @@ -1022,6 +1022,8 @@ static int imx412_power_on(struct device *dev)
>>   	struct imx412 *imx412 = to_imx412(sd);
>>   	int ret;
>>   
>> +	gpiod_set_value_cansleep(imx412->reset_gpio, 1);
> 
> I'd assert reset in probe() so you can drop this line.

Sure, will update the patch.

Thanks,
Wenmeng