linux-kernel - Re: [PATCH] drm/rockchip: vop2: Add mode valid callback for crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPj87rNJ_ELo0C7u5Qqqhg5br8kar+f7DjcKd6Oxkr1uETsVAQ@mail.gmail.com>
Date: Tue, 20 Jan 2026 11:24:09 +0000
From: Daniel Stone <daniel@...ishbar.org>
To: Andy Yan <andyshrk@....com>
Cc: heiko@...ech.de, hjc@...k-chips.com, dri-devel@...ts.freedesktop.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, airlied@...il.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, simona@...ll.ch, 
	Andy Yan <andy.yan@...k-chips.com>
Subject: Re: [PATCH] drm/rockchip: vop2: Add mode valid callback for crtc

Hi Andy,

On Tue, 20 Jan 2026 at 11:03, Daniel Stone <daniel@...ishbar.org> wrote:
> On Fri, 9 Jan 2026 at 00:59, Andy Yan <andyshrk@....com> wrote:
> > Filter the mode that can't output by the crtc.
> >
> > [...]
> >
> > +static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc,
> > +                                                const struct drm_display_mode *mode)
> > +{
> > +       struct vop2_video_port *vp = to_vop2_video_port(crtc);
> > +
> > +       if (mode->hdisplay > vp->data->max_output.width)
> > +               return MODE_BAD_HVALUE;
>
> Why not test height as well?

I see the question was answered about 45 minutes ago ... anyway, why
not as a follow-up, change struct vop_rect max_output to just a single
max_width value?

Cheers,
Daniel