linux-kernel - RE: [PATCH 01/10] dt-bindings: PCI: fsl,imx6q-pcie: Add reset GPIO in Root Port node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <VI0PR04MB12114BBB33DD944C2175868329289A@VI0PR04MB12114.eurprd04.prod.outlook.com>
Date: Tue, 20 Jan 2026 02:22:44 +0000
From: Sherry Sun <sherry.sun@....com>
To: Frank Li <frank.li@....com>
CC: Hongxing Zhu <hongxing.zhu@....com>, "l.stach@...gutronix.de"
	<l.stach@...gutronix.de>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>, "kwilczynski@...nel.org"
	<kwilczynski@...nel.org>, "mani@...nel.org" <mani@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 01/10] dt-bindings: PCI: fsl,imx6q-pcie: Add reset GPIO in
 Root Port node



> On Mon, Jan 19, 2026 at 06:02:26PM +0800, Sherry Sun wrote:
> > Update the fsl,imx6q-pcie.yaml to include the reset-gpios property in
> > the Root Port node.
> >
> > There is already 'reset-gpios' property defined for PERST# in
> > pci-bus-common.yaml, so use that property instead of 'reset-gpio' in
> > this file, for backward compatibility, do not remove the existing
> > property in the bridge node, but mark them as 'deprecated' instead.
> 
> 
> Update fsl,imx6q-pcie.yaml to include the standard reset-gpios property for
> the Root Port node.
> 
> The reset-gpios property is already defined in pci-bus-common.yaml for
> PERST#, so use it instead of the local reset-gpio property. Keep the existing
> reset-gpio property in the bridge node for backward compatibility, but mark it
> as deprecated.
> 

Hi Frank, ok, will improve the commit message in V2, thanks!

Best Regards
Sherry

> 
> Frank
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >  .../bindings/pci/fsl,imx6q-pcie.yaml          | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 12a01f7a5744..74156b42e7a2 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -59,9 +59,12 @@ properties:
> >        - const: dma
> >
> >    reset-gpio:
> > +    deprecated: true
> >      description: Should specify the GPIO for controlling the PCI bus device
> >        reset signal. It's not polarity aware and defaults to active-low reset
> >        sequence (L=reset state, H=operation state) (optional required).
> > +      This property is deprecated, instead of referencing this property from
> the
> > +      host bridge node, use the reset-gpios property from the root port
> node.
> >
> >    reset-gpio-active-high:
> >      description: If present then the reset sequence using the GPIO @@
> > -69,6 +72,18 @@ properties:
> >        L=operation state) (optional required).
> >      type: boolean
> >
> > +  pcie@0:
> > +    description:
> > +      Describe the i.MX6 PCIe Root Port.
> > +    type: object
> > +    $ref: /schemas/pci/pci-pci-bridge.yaml#
> > +
> > +    properties:
> > +      reg:
> > +        maxItems: 1
> > +
> > +    unevaluatedProperties: false
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -229,6 +244,7 @@ unevaluatedProperties: false
> >  examples:
> >    - |
> >      #include <dt-bindings/clock/imx6qdl-clock.h>
> > +    #include <dt-bindings/gpio/gpio.h>
> >      #include <dt-bindings/interrupt-controller/arm-gic.h>
> >
> >      pcie: pcie@...c000 {
> > @@ -255,5 +271,18 @@ examples:
> >                  <&clks IMX6QDL_CLK_LVDS1_GATE>,
> >                  <&clks IMX6QDL_CLK_PCIE_REF_125M>;
> >          clock-names = "pcie", "pcie_bus", "pcie_phy";
> > +
> > +        pcie_port0: pcie@0 {
> > +            compatible = "pciclass,0604";
> > +            device_type = "pci";
> > +            reg = <0x0 0x0 0x0 0x0 0x0>;
> > +            bus-range = <0x01 0xff>;
> > +
> > +            #address-cells = <3>;
> > +            #size-cells = <2>;
> > +            ranges;
> > +
> > +            reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
> > +        };
> >      };
> >  ...
> > --
> > 2.37.1
> >