linux-kernel - Re: [PATCH 01/17] drm/amd/display: Return if DisplayID not found in parse_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <222c4c14ee6c20f18381580b249d160d197ce3e4.camel@gmail.com>
Date: Tue, 20 Jan 2026 13:07:03 +0100
From: Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>, alexander.deucher@....com, 
	harry.wentland@....com, sunpeng.li@....com
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, 	airlied@...il.com, simona@...ll.ch,
 siqueira@...lia.com, 	dri-devel@...ts.freedesktop.org,
 amd-gfx@...ts.freedesktop.org, 	linux-kernel@...r.kernel.org,
 bernhard.berger@...il.com
Subject: Re: [PATCH 01/17] drm/amd/display: Return if DisplayID not found in
 parse_amd_vsdb()

On Mon, 2026-01-19 at 15:23 +0200, Jani Nikula wrote:
> On Mon, 19 Jan 2026, Tomasz Pakuła <tomasz.pakula.oficjalny@...il.com> wrote:
> > [Why]
> > The function would continue to try to parse EDID even if DisplayID
> > extension block wasn't found. Sometimes it got lucky and found AMD vsdb
> > in CEA extension block which made debugging harder.
> > 
> > [How]
> > Add a return if DisplayID extension block wasn't found
> 
> Maybe don't use homegrown EDID parsing, but use drm_edid.c instead?
> 
> BR,
> Jani.
> 

I would be all for it but I didn't want to make even more changes. I
cannot refactor the whole amdgpu on my own :)

Plus, the generic drm code doesn't yet parse AMD vsdb. I could certainly
add such functionality, especially since it's already in projects like
edid-decode but amdgpu seems to be doing a lot of home-grown edid
parsing and I'm not really sure why, even sending stuff to firmware.

Especially confusing is the part where AMD vsdb is parsed differently if
it's in CTA extensiton block or DisplayID. They honestly are identical.

At least, here in, setting the freesync caps, getting info from generic
drm should be ok. I'll think about it and probably intoroduce AMD vsdb
parsing to drm in a separate series.

> 
Tomasz