linux-kernel - Re: [PATCH v2 1/2] rtl8723bs: Refactor continual_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012117-blinks-smitten-5874@gregkh>
Date: Wed, 21 Jan 2026 14:27:38 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: 2023060904@....edu.cn, linux-staging@...ts.linux.dev,
	guagua210311@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rtl8723bs: Refactor continual_io_error check

On Wed, Jan 21, 2026 at 04:22:44PM +0300, Dan Carpenter wrote:
> On Tue, Jan 20, 2026 at 10:11:25PM +0800, 2023060904@....edu.cn wrote:
> > From: Changjun Zheng <guagua210311@...com>
> > 
> > Refactor the error count check logic to follow kernel 'single responsibility' principle:
> > 1. Move the increment logic (atomic_inc) from rtw_inc_and_chk_continual_io_error() to its callers in sdio_ops_linux.c (line 226/302)
> > 2. Keep only the check logic in rtw_inc_and_chk_continual_io_error() (use atomic_read to get current count)
> > 
> > This change addresses Greg KH's feedback to move increment to callers, while keeping atomic operations to ensure no compilation/run-time errors.
> > 
> 
> There are a lot of style issues in this patch.  I also still don't
> really understand why we are doing this.  Was Greg's email this one?
> 
> https://lore.kernel.org/all/2025121757-crowbar-junkman-a96a@gregkh/
> 
> I'm guessing that Greg wants you to change this to refcount_t.

Nope!  Please don't do that, it's not needed at all.

greg k-h