linux-kernel - Re: [PATCH net v2] net: openvswitch: fix data race in ovs_vport_get_upcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK6_eoc56uTHiAJbFTyddmzLu3pp364j9djdO6H51utiw@mail.gmail.com>
Date: Wed, 21 Jan 2026 14:29:23 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: David Yang <mmyangfl@...il.com>
Cc: netdev@...r.kernel.org, Aaron Conole <aconole@...hat.com>, 
	Eelco Chaudron <echaudro@...hat.com>, Ilya Maximets <i.maximets@....org>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, wangchuanlei <wangchuanlei@...pur.com>, dev@...nvswitch.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: openvswitch: fix data race in ovs_vport_get_upcall_stats

On Wed, Jan 21, 2026 at 8:32 AM David Yang <mmyangfl@...il.com> wrote:
>
> In ovs_vport_get_upcall_stats(), some statistics protected by
> u64_stats_sync, are read and accumulated in ignorance of possible
> u64_stats_fetch_retry() events. These statistics are already accumulated
> by u64_stats_inc(). Fix this by reading them into temporary variables
> first.
>
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Signed-off-by: David Yang <mmyangfl@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>