linux-kernel - Re: request_irq() usage in wm8350_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fcb799a-de89-47e0-a38a-a3a828d0b834@sirena.org.uk>
Date: Wed, 21 Jan 2026 13:37:09 +0000
From: Mark Brown <broonie@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
	Lee Jones <lee@...nel.org>
Subject: Re: request_irq() usage in wm8350_register_irq().

On Wed, Jan 21, 2026 at 02:18:11PM +0100, Sebastian Andrzej Siewior wrote:

> I've been staring wm8350_register_irq(). It does

> | request_threaded_irq(irq + wm8350->irq_base, NULL,
> | 		handler, flags, name, data);

> and every single user passes 0 as flags. This means it asks for a
> threaded IRQ and does not pass IRQF_ONESHOT.

> So either this is not working because it triggers the warnings
> 	Threaded irq requested with handler=NULL and !ONESHOT

> followed by -EINVAL _or_ every single user of this driver sits in
> system where the irqchip is IRQCHIP_ONESHOT_SAFE marked.
> Which is it?

The chip is only accessable via I2C or SPI so the primary interrupt
handler is itself always running and reporting child interrupts in
threaded context.  They can't really deliver a hardirq context
interrupt.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)