linux-kernel - Re: [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00407e04-2d97-4770-97d2-399c520e38cd@kernel.org>
Date: Wed, 21 Jan 2026 08:28:26 -0600
From: "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>
To: Borislav Petkov <bp@...en8.de>
Cc: Yazen Ghannam <yazen.ghannam@....com>, Jean Delvare <jdelvare@...e.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd



On 1/21/2026 4:49 AM, Borislav Petkov wrote:
> On Wed, Jan 21, 2026 at 12:04:30AM -0600, Mario Limonciello (AMD) wrote:
>> To clarify which messages come from arch/x86/kernel/cpu/amd.c add
>> a prefix to all messages instead of just the previous reset reason.
>>
>> Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>
>> Signed-off-by: Mario Limonciello (AMD) <superm1@...nel.org>
>> ---
>> v3:
>>   * add tag, put in it's own series
>> ---
>>   arch/x86/kernel/cpu/amd.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
>> index bc94ff1e250ad..c19c4ee74dd1f 100644
>> --- a/arch/x86/kernel/cpu/amd.c
>> +++ b/arch/x86/kernel/cpu/amd.c
>> @@ -1,4 +1,6 @@
>>   // SPDX-License-Identifier: GPL-2.0-only
>> +#define pr_fmt(fmt) "x86/amd: " fmt
> 
> I'm still not sure about this. There are a lot of places which you can call
> "x86/amd:" - not only this one. So if anything, this prefix should be called
> "x86/CPU:".
> 
> But looking at cpu/intel.c, they have "x86/tme:" and "x86/mktme:" prefixes
> there for the TME specific stuff.
> 
> So I still don't see a clear working logic to apply to x86/cpu/ compilation
> units.
> 
> So unless there's a better idea, pls drop this for now.
> 
> Thx.
> 

Well so if I drop this patch, I still want to apply some sort of prefix 
to patch 6/6.  Because otherwise you end up with an AGESA string with no 
context of what that actually means or goes with.

Any other ideas of what to prefix that with?  Maybe:
pr_info("AMD BIOS: %s\n")