linux-kernel - Re: [PATCH v8 3/4] i2c: tegra: Add logic to support different register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f730c0c4-42ff-495b-a9a2-c61e6391d2be@nvidia.com>
Date: Wed, 21 Jan 2026 21:06:53 +0530
From: Kartik Rajput <kkartik@...dia.com>
To: Jon Hunter <jonathanh@...dia.com>, ldewangan@...dia.com,
 digetx@...il.com, andi.shyti@...nel.org, thierry.reding@...il.com,
 akhilrajeev@...dia.com, smangipudi@...dia.com, linux-i2c@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 3/4] i2c: tegra: Add logic to support different
 register offsets

Hi Jon,

Thanks for reviewing the patch!

On 21/01/26 20:00, Jon Hunter wrote:
> 
> 
> On 20/01/2026 09:20, Kartik Rajput wrote:
>> Tegra410 use different offsets for existing I2C registers, update
>> the logic to use appropriate offsets per SoC.
>>
>> As the registers offsets are now also defined for dvc and vi, following
> 
> So this is still not accurate because the DVC offsets definition have not changed.
> 
>> -static void dvc_writel(struct tegra_i2c_dev *i2c_dev, u32 val,
>> -               unsigned int reg)
>> -{
>> -    writel_relaxed(val, i2c_dev->base + reg);
>> -}
>> -
>> -static u32 dvc_readl(struct tegra_i2c_dev *i2c_dev, unsigned int reg)
>> -{
>> -    return readl_relaxed(i2c_dev->base + reg);
>> -}
> 
> ...
> 
>> @@ -619,14 +712,14 @@ static void tegra_dvc_init(struct tegra_i2c_dev *i2c_dev)
>>   {
>>       u32 val;
>> -    val = dvc_readl(i2c_dev, DVC_CTRL_REG3);
>> +    val = i2c_readl(i2c_dev, DVC_CTRL_REG3);
>>       val |= DVC_CTRL_REG3_SW_PROG;
>>       val |= DVC_CTRL_REG3_I2C_DONE_INTR_EN;
>> -    dvc_writel(i2c_dev, val, DVC_CTRL_REG3);
>> +    writel_relaxed(val, i2c_dev->base + DVC_CTRL_REG3);
>> -    val = dvc_readl(i2c_dev, DVC_CTRL_REG1);
>> +    val = i2c_readl(i2c_dev, DVC_CTRL_REG1);
>>       val |= DVC_CTRL_REG1_INTR_EN;
>> -    dvc_writel(i2c_dev, val, DVC_CTRL_REG1);
>> +    writel_relaxed(val, i2c_dev->base + DVC_CTRL_REG1);
>>   }
> 
> Looking at the above, I think I would be tempted to leave this as-is and not make any changes here to reduce the diff.
> 

I have posted v9 with dvc_readl/writel related modifications removed.

Thanks,
Kartik