linux-kernel - Re: [PATCH v4 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121022449.GA1804139-robh@kernel.org>
Date: Tue, 20 Jan 2026 20:24:49 -0600
From: Rob Herring <robh@...nel.org>
To: Swati Agarwal <swati.agarwal@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Icenowy Zheng <uwu@...nowy.me>,
	Matthias Kaehlcke <mka@...omium.org>,
	Mike Looijmans <mike.looijmans@...ic.nl>,
	Stephen Boyd <swboyd@...omium.org>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	Jens Glathe <jens.glathe@...schoolsolutions.biz>,
	Chaoyi Chen <chaoyi.chen@...k-chips.com>,
	J . Neuschäfer <j.ne@...teo.net>,
	Pin-yen Lin <treapking@...omium.org>,
	Catalin Popescu <catalin.popescu@...ca-geosystems.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: usb: Add binding for Genesys Logic
 GL3590 hub

On Tue, Jan 20, 2026 at 04:03:09PM +0530, Swati Agarwal wrote:
> Add the binding for the USB3.2 Genesys Logic GL3590 hub.
> GL3590 hub requires 1.2V and 3.3V supplies for operation.
> 
> Signed-off-by: Swati Agarwal <swati.agarwal@....qualcomm.com>
> ---
>  .../devicetree/bindings/usb/genesys,gl850g.yaml | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index 9a94b2a74a1e..a4a359000ca1 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -15,6 +15,7 @@ properties:
>        - usb5e3,608
>        - usb5e3,610
>        - usb5e3,620
> +      - usb5e3,625
>        - usb5e3,626
>  
>    reg: true
> @@ -26,6 +27,10 @@ properties:
>      description:
>        The regulator that provides 3.3V or 5.0V core power to the hub.
>  
> +  vdd12-supply:
> +    description:
> +      The regulator that provides 1.2V power to the hub.
> +
>    peer-hub: true
>  
>    ports:
> @@ -69,6 +74,18 @@ allOf:
>          peer-hub: true
>          vdd-supply: true
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - usb5e3,625
> +    then:
> +      properties:
> +        peer-hub: true
> +        vdd-supply: true
> +        vdd12-supply: true

true is the default, so this does nothing. It's all the existing 
compatibles that should disallow vdd12-supply.

Rob