linux-kernel - Re: [PATCH] rust: disallow use of `CStr::as

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFUG45Y0U7IS.32I4NMAV9NHT6@garyguo.net>
Date: Wed, 21 Jan 2026 17:33:09 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>, "Gary Guo"
 <gary@...yguo.net>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
 Krummrich" <dakr@...nel.org>, "Tamir Duberstein" <tamird@...il.com>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: disallow use of `CStr::as_ptr`

On Wed Jan 21, 2026 at 5:04 PM GMT, Miguel Ojeda wrote:
> On Wed, Jan 21, 2026 at 5:58 PM Gary Guo <gary@...nel.org> wrote:
>>
>> +#[expect(clippy::disallowed_methods, reason = "internal implementation")]
>
> Should we hide them too?

These are the methods that we want people to use? The "internal implementation"
means that the use of `CStr::as_char()` is the internal implementation detail of
`as_char_ptr` so it's okay. But nobody else should use it.

Best,
Gary

>
> Cheers,
> Miguel