linux-kernel - Re: [PATCH v9 07/22] KVM: VMX: Initialize VMCS FRED fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9F630202-905B-43D7-9DBF-6E4551BAF082@zytor.com>
Date: Wed, 21 Jan 2026 10:14:15 -0800
From: Xin Li <xin@...or.com>
To: Binbin Wu <binbin.wu@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, pbonzini@...hat.com, seanjc@...gle.com,
        corbet@....net, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        luto@...nel.org, peterz@...radead.org, andrew.cooper3@...rix.com,
        chao.gao@...el.com, hch@...radead.org, sohil.mehta@...el.com
Subject: Re: [PATCH v9 07/22] KVM: VMX: Initialize VMCS FRED fields



> On Jan 20, 2026, at 10:44 PM, Binbin Wu <binbin.wu@...ux.intel.com> wrote:
> 
>> +#ifdef CONFIG_X86_64
> 
> Nit:
> 
> Is this needed?
> 
> FRED is initialized by X86_64_F(), if CONFIG_X86_64 is not enabled, this
> path is not reachable.
> There should be no compilation issue without #ifdef CONFIG_X86_64 / #endif.
> 
> There are several similar patterns in this patch, using  #ifdef CONFIG_X86_64 / 
> #endif or not seems not consistent. E.g. __vmx_vcpu_reset() and init_vmcs()
> doesn't check the config, but here does.


I tried removing all such #ifdef, and it turned out that I had to keep this
per the last round of build checks.

Anyway, I will do another build check on x86_32.