linux-kernel - Re: [PATCH v3 1/4] of: reserved_mem: Fix placement of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176896265605.1837058.2000534852582541394.robh@kernel.org>
Date: Tue, 20 Jan 2026 20:30:58 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Gregory CLEMENT <gregory.clement@...tlin.com>
Cc: Vignesh Raghavendra <vigneshr@...com>,
	linux-arm-kernel@...ts.infradead.org,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org,
	linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Théo Lebrun <theo.lebrun@...tlin.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Benoît Monin <benoit.monin@...tlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v3 1/4] of: reserved_mem: Fix placement of __free()
 annotation


On Wed, 07 Jan 2026 14:04:52 +0100, Gregory CLEMENT wrote:
> The __free() annotation was incorrectly placed before the variable
> name instead of after it, which resulted in the following checkpatch
> errors:
> 
> ERROR: need consistent spacing around '*' (ctx:WxV)
> +       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
>                                                ^
> WARNING: function definition argument 'idx' should also have an identifier name
> +       struct device_node __free(device_node) *target = of_parse_phandle(np, "memory-region", idx);
> 
> As part of this cleanup, also remove the useless return statement
> flagged by checkpatch.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
> ---
>  drivers/of/of_reserved_mem.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied, thanks!