linux-kernel - Re: [RFC][PATCH 2/4] locking/mutex: Add context analysis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bd8f6cd-463c-45cf-80b3-5b9d123afb61@acm.org>
Date: Wed, 21 Jan 2026 09:11:53 -0800
From: Bart Van Assche <bvanassche@....org>
To: Peter Zijlstra <peterz@...radead.org>, elver@...gle.com
Cc: linux-kernel@...r.kernel.org, bigeasy@...utronix.de, mingo@...nel.org,
 tglx@...utronix.de, will@...nel.org, boqun.feng@...il.com,
 longman@...hat.com, hch@....de, rostedt@...dmis.org, llvm@...ts.linux.dev
Subject: Re: [RFC][PATCH 2/4] locking/mutex: Add context analysis

On 1/21/26 3:07 AM, Peter Zijlstra wrote:
> @@ -565,6 +574,8 @@ EXPORT_SYMBOL(mutex_unlock);
>    * of a unlocked mutex is not allowed.
>    */
>   void __sched ww_mutex_unlock(struct ww_mutex *lock)
> +	__releases(lock)
> +	__no_context_analysis
>   {
>   	__ww_mutex_unlock(lock);
>   	mutex_unlock(&lock->base);

"__releases()" annotations should be added to the declaration of a
function only instead of the definition, isn't it?

> @@ -824,22 +838,27 @@ EXPORT_SYMBOL(ww_mutex_trylock);
>   #ifdef CONFIG_DEBUG_LOCK_ALLOC
>   void __sched
>   mutex_lock_nested(struct mutex *lock, unsigned int subclass)
> +	__acquires(lock)

Same comment here and below for the "__acquires()" annotation: I think
this annotation should be added to the function declaration only.

Thanks,

Bart.