linux-kernel - Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5f285fb4-8946-45aa-8b08-9dc7f0ab1170@app.fastmail.com>
Date: Wed, 21 Jan 2026 11:44:27 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Derek J . Clark" <derekjohn.clark@...il.com>,
 "Jiri Kosina" <jikos@...nel.org>
Cc: "Benjamin Tissoires" <bentiss@...nel.org>,
 "Limonciello, Mario" <mario.limonciello@....com>,
 "Zhixin Zhang" <zhangzx36@...ovo.com>, "Mia Shao" <shaohz1@...ovo.com>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 linux-input@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID
 Driver

On Wed, Jan 21, 2026, at 8:16 AM, Derek J. Clark wrote:
> On January 21, 2026 1:08:18 AM PST, Jiri Kosina <jikos@...nel.org> wrote:
>>On Mon, 12 Jan 2026, Mark Pearson wrote:
>>
>>> >>I am now almost finished with reviewing this pile and am planning to queue 
>>> >>it in hid.git shortly, but I have a question regarding the MAINTAINERS 
>>> >>entry above.
>>> >>
>>> >>The title claims support for all of Lenovo HID, but there is much more to 
>>> >>it than drivers/hid/hid-lenovo-go.c, specifically in hid-lenovo.c.
>>> >>
>>> >>So either please make the title more specific (or claim the ownership of 
>>> >>the whole Lenovo HID landscape indeed, fine by me, but the please reflect 
>>> >>that in F: :) ).
>>> >>
>>> >>Thanks,
>>> >>
>>> >
>>> > Hi Jiri
>>> >
>>> > Sure, I've debated using LENOVO LEGION GO HID drivers and LENOVO GO HID 
>>> > drivers. Do you have a preference? 
>>
>>Either works, as far as I am concerned.
>>
>>> > The other drivers are pretty old and I don't have any hardware that 
>>> > would use them so I'd prefer to keep them separate (though I'll 
>>> > acknowledge that they don't seem to have a MAINTAINERS entry)
>>> >
>>> I should probably take a better look at the lenovo-hid driver.
>>> 
>>> The platforms that it's supporting weren't in the Linux program, so it 
>>> never crossed my path before - but looking ahead I think we may need to 
>>> contribute some changes there (guessing a little, but I'll know in a few 
>>> months time).
>>> 
>>> Jiri - as that driver is targeted for Thinkpads, I'm OK to take some 
>>> responsibility for it if that is useful/helpful.
>>
>>Perfect, could you please then either send that as a followup patch, or 
>>even have it included right as part of Derek's series?
>>
>
> If Mark is okay with it I'll just add him and that driver to the same entry.
>
No problem for me. 
I always feel my reviews are limited, but I do try and read everything and help wherever I can.

Mark