[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <95b13260-0564-445d-bff7-b3b54fa15005@baylibre.com>
Date: Wed, 21 Jan 2026 11:43:03 -0600
From: David Lechner <dlechner@...libre.com>
To: Nuno Sá <noname.nuno@...il.com>,
Marcelo Schmitt <marcelo.schmitt1@...il.com>, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: jic23@...nel.org, Jonathan.Cameron@...wei.com, nuno.sa@...log.com,
andy@...nel.org
Subject: Re: [RFC PATCH v1 0/9] iio: Expand IIO event interface for real-world
unit handling
On 1/21/26 3:33 AM, Nuno Sá wrote:
> On Sun, 2026-01-18 at 14:33 -0600, David Lechner wrote:
>> On 1/18/26 12:18 PM, Marcelo Schmitt wrote:
>>> This patch set adjusts and complements the IIO event ABI docs making them
>>> coherent with the fact that not all threshold value attributes had a _raw/_input
>>> indicator set in their names. In addition that, the latter patches on this
>>> series update the IIO event infrastructure to actually enable drivers to provide
>>> _input threshold value attributes.
>>
>
> ...
>
>>
>> Just throwing out an idea here without thinking about it too much...
>>
>> Instead of adding a new field/parameter for units, could we extend
>> enum iio_event_info to add IIO_EV_INFO_VALUE_RAW and IIO_EV_INFO_VALUE_INPUT
>> (and same for HYSTERESIS). Really, the units only make sense for these
>> two info types anyway.
>>
>
> Makes sense to me. Or we can just document that the old value is _INPUT? Or just make
> it the same value in the enum.
>
> - Nuno Sá
I don't think that works since IIO_EV_INFO_VALUE could be _RAW or _INPUT
depending on the driver. And another point was that this should also
control the _raw or _input in the attribute name, and we can't change the
existing attribute names.
Powered by blists - more mailing lists